[IMP] util/pg: cache column_exists for common columns #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
upgradeci retry with always hr* _hr |
aj-fuentes
force-pushed
the
master-imp_cache_column_exists-afu
branch
from
4d381c4 to
aff56cc
Compare
KangOl
reviewed
Jun 18, 2025
src/util/pg.py
Outdated
Comment on lines
486
to
499
| def _forced_cache(cache): | ||
| def decorator(f): | ||
| @functools.wraps(f) | ||
| def wrapper(cr, *args, **kwargs): | ||
| if not kwargs and tuple(args) in cache: | ||
| return cache[tuple(args)] | ||
| return f(cr, *args, **kwargs) | ||
|
|
||
| return wrapper | ||
|
|
||
| return decorator | ||
|
|
||
|
|
||
| @_forced_cache(_COLUMNS) |
There was a problem hiding this comment.
I don't think the decorator is needed. It can be inline into the function directly.
def column_exists(cr, table, column):
if (table, column) in _COLUMNS:
return _COLUMNS[(table, column)]
return _column_info(cr, table, column) is not NoneThere was a problem hiding this comment.
Well, originally I was using it in get_value_or_en_translation. It proved not as useful. I'm still working on this, I will simplify as much as possible before the final version. There are still some other columns being checked more than 70 times in the local test I'm doing.
|
In many cases we know that columns must exist, it's better to cache them to avoid thousands of small queries.
aj-fuentes
force-pushed
the
master-imp_cache_column_exists-afu
branch
from
aff56cc to
66473d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many cases we know that columns must exist, it's better to cache them
to avoid thousands of small queries.