Skip to content

unlock mouse from center when panning magnifier#19782

Draft
Boumtchack wants to merge 1 commit intonvaccess:masterfrom
France-Travail:fix/keepMouseCentered
Draft

unlock mouse from center when panning magnifier#19782
Boumtchack wants to merge 1 commit intonvaccess:masterfrom
France-Travail:fix/keepMouseCentered

Conversation

@Boumtchack
Copy link
Contributor

Link to issue number:

fix #19708

Summary of the issue:

Mouse was kept in the center of the screen even if the settings was set on false

Description of user facing changes:

Keep mouse centered works properly with panning

Description of developer facing changes:

adding 2 function to better manage panning and mouse center

Description of development approach:

used better condition to update magnifier.

Testing strategy:

Manual

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd
Copy link
Member

@Boumtchack - it is becoming quite hard for us to manage so many concurrent magnifier PRs. Could you please avoid opening new ones until the current ones are complete?

@seanbudd seanbudd changed the title unlock mouse from center when panning unlock mouse from center when panning magnifier Mar 17, 2026
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Magnifier - The mouse cursor remains centered, no matter the value of "Keep mouse pointer centered in magnifier view"

2 participants