feat: introduce a generic map for per message nack options#3539
Merged
Conversation
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
vaibhavtiwari33
marked this pull request as ready for review
July 15, 2026 20:49
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3539 +/- ##
==========================================
+ Coverage 83.15% 83.20% +0.05%
==========================================
Files 310 310
Lines 81554 81995 +441
==========================================
+ Hits 67817 68228 +411
- Misses 13141 13171 +30
Partials 596 596 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vigith
reviewed
Jul 16, 2026
vigith
left a comment
vigith
left a comment
Member
There was a problem hiding this comment.
please add a doc as mentioned in numaproj/numaflow-rs#184 (review)
yhl25
enabled auto-merge (squash)
July 17, 2026 01:27
yhl25
disabled auto-merge
July 17, 2026 01:27
yhl25
approved these changes
Jul 17, 2026
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Contributor
Author
|
Updated per message nack documentation with the generic map usage across SDKs |
vaibhavtiwari33
enabled auto-merge (squash)
July 18, 2026 20:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Introduces a generic map as part of NackOptions
Related issues
Fixes #3540
Testing
Tests utilizing the new map will be added once we have changes merged to main of Rust SDK.