feat(ui): add success feedback banner after sync/restart completes#433
Open
feat(ui): add success feedback banner after sync/restart completes#433
Conversation
When the user clicks "Restart" to apply dependency changes, there was no visual confirmation that it worked - the amber banner just disappeared silently. Now shows a green "Environment synced — dependencies are ready to use" banner for 3 seconds after a successful sync/restart for: - UV inline deps - Conda inline deps - Deno config changes This gives the user confidence that their action succeeded.
Previously, when send_request was waiting for a response (like during LaunchKernel), broadcasts received during that time were queued in pending_broadcasts and only delivered after the response arrived. This meant progress events during environment creation were all delivered at once after completion, breaking the "progressive" experience. The fix passes the broadcast_tx channel to wait_for_response_with_broadcast, which now delivers broadcasts immediately as they arrive via try_send. This allows progress bars to update in real-time during long-running requests like conda environment creation.
After an environment creation error: 1. When user modifies dependencies (sync state becomes dirty), the error banner automatically clears so they can see the "Restart" button 2. When user clicks sync/restart, error is reset before the new attempt This allows recovery from transient errors like bad package names without requiring manual dismissal of the error banner.
Address code review feedback: - When try_send fails due to full channel, queue the broadcast in pending_broadcasts instead of dropping it. This prevents loss of terminal events (ready, error) which are critical for UI state. - Remove debug console.log statements from useEnvProgress.ts that were flooding logs during environment installation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When users click "Restart" to apply dependency changes, there was no visual confirmation that it worked - the amber banner just disappeared silently.
Screenshots
Before: Amber banner shows changes needed, then... nothing after restart
After: Amber banner → Green success banner for 3s → Clean state
Test Plan
Note on Rattler Progress
The rattler progress bars already exist and work correctly during fresh conda env creation. When an env is cached (common after first use), it shows
cache_hitimmediately and there's no progress to display - just instant kernel start. The success banner helps provide feedback in this case.