-
Notifications
You must be signed in to change notification settings - Fork 272
Move some core type into internal & migrate to slnx #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -10,7 +10,7 @@ ICalculator calculator; | |||
``` | |||
--> | |||
|
|||
The `Throws` and `ThrowsAsync` helpers in the `NSubstitute.ExceptionExtensions` namespace can be used to throw exceptions when a member is called. | |||
The `Throws` and `ThrowsAsync` helpers in the `NSubstitute.Extensions` namespace can be used to throw exceptions when a member is called. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this some other change, as it isn't the internal namespace?
Are more namespaces changed in this PR?
Initially the The MR looks good, will approve pending feedback on @304NotModified's comments. 👍 |
@dtchepak |
Haha, yes, sorry. I do a lot with gitlab where they're known as Merge Requests. |
@304NotModified thank you for your feedback. I'm afraid that this approach will make more problems then solve Lets save status quo for now and don't do anything with it |
Changes:
This PR is a follow up for discussion #869 and alternaltive solution when we don't what make these types "true" internal\sealed but still want to logically separate these types
Core types that are still "public" core namespace:
Related #830