-
Notifications
You must be signed in to change notification settings - Fork 2.6k
chore(repo): split slow e2e tests - web, webpack, and workspace-create #33011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Split the following test suites into smaller, more focused tests: - web tests (decorator babel/swc, env variables, generate, html interpolation, new format, vite) - webpack tests (app plugin, assets, babel, compose plugins, config variations, env variables, executor options, node compilers) - workspace-create npm tests (angular, express, init, js, nest, next, node, react-native, react, web)
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
View your CI Pipeline Execution ↗ for commit cbf5d75
☁️ Nx Cloud last updated this comment at |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2e9c905
to
979802a
Compare
const envFileContents = ` | ||
NX_PUBLIC_VARIABLE=foo | ||
SOME_OTHER_VARIABLE=bar | ||
}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a syntax error in the environment file content - the closing curly brace }
at the end of the string is invalid for an .env file format. This would create a malformed environment file that won't be properly parsed. The brace should be removed to ensure proper environment variable loading.
const envFileContents = ` | |
NX_PUBLIC_VARIABLE=foo | |
SOME_OTHER_VARIABLE=bar | |
}`; | |
const envFileContents = ` | |
NX_PUBLIC_VARIABLE=foo | |
SOME_OTHER_VARIABLE=bar | |
`; |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
Classification: environment_state
The failure is classified as 'environment_state' based on the following analysis:
-
Nature of the failure:
- All 10 failing tests fail at the same point: yarn dependency installation during workspace creation
- The error "NX Failed to install dependencies" with exit code 1 indicates an external package manager issue
- The "spawnSync /bin/sh ENOENT" error indicates the system cannot spawn shell processes, which is a system-level issue
-
Lack of correlation with PR changes:
- The PR splits slow e2e tests for web, webpack, and workspace-create test suites
- The failing test is e2e-remix, which is not mentioned anywhere in the PR title, body, or commit messages
- No remix-related files appear in the diff
- The changes involve creating new test files for web and webpack tests, not modifying remix test behavior
-
Environmental indicators present:
- Package manager (yarn) failures
- External service dependency (npm registry for package resolution)
- System process spawning failures
-
No direct evidence linking code changes to failures:
- The error occurs during dependency installation, not during test execution
- No changed code would cause yarn to fail installing dependencies
- The failure happens before any test-specific logic runs
- The same workspace creation command that fails here would have worked before if the environment was stable
-
Default assumption validation:
- When in doubt, classify as 'environment_state' or 'flaky_task'
- Package manager failures are common environmental issues
- The failure is in an unrelated test suite to the PR changes
- No code correlation exists between splitting test suites and yarn installation failures
The evidence strongly supports that this is an environmental issue with the CI environment's ability to install dependencies via yarn, rather than an issue introduced by the code changes in this PR.
A code change would likely not resolve this issue, so no action was taken.
🎓 To learn more about Self Healing CI, please visit nx.dev
- e2e-ci**module-federation/misc-rspack-interoperability** | ||
- e2e-ci**module-federation/dynamic-federation.webpack** | ||
- e2e-ci**docker** | ||
- e2e-ci**module-federation/misc-rspack-interoperability** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a duplicate entry for e2e-ci**module-federation/misc-rspack-interoperability**
in the targets list (lines 42 and 45). One of these entries should be removed to prevent the same test from running twice unnecessarily.
- e2e-ci**module-federation/misc-rspack-interoperability** | |
- e2e-ci**module-federation/dynamic-federation.webpack** | |
- e2e-ci**docker** | |
- e2e-ci**module-federation/misc-rspack-interoperability** | |
- e2e-ci**module-federation/misc-rspack-interoperability** | |
- e2e-ci**module-federation/dynamic-federation.webpack** | |
- e2e-ci**docker** |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
ef1bf02
to
ec2c864
Compare
ec2c864
to
cbf5d75
Compare
Split the following test suites into smaller, more focused tests:
Fixes CLOUD-3756
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #