Skip to content

fix(core): fix broken nx-cloud url shortening logic #31283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented May 20, 2025

Current URL shortening logic is based on the old Nx Cloud version format - YYMM.DD.BuildVersion.

Since, 2025 we changed that format to YYYY.MM.BuildVersion which breaks this logic and causes the connection URL to be just host.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this May 20, 2025
@meeroslav meeroslav requested review from MaxKless and a team as code owners May 20, 2025 12:00
Copy link

vercel bot commented May 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 22, 2025 11:51am

Copy link

nx-cloud bot commented May 20, 2025

View your CI Pipeline Execution ↗ for commit 5990e41.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 34m 20s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 16s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 3s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 2s View ↗
nx documentation ✅ Succeeded 2m 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-22 12:25:04 UTC

@meeroslav meeroslav requested a review from StalkAltan May 20, 2025 12:03
@meeroslav meeroslav force-pushed the fix/url-shortening-for-post-2025-nx-cloud-versions branch from 8e3a96d to 5976f36 Compare May 21, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants