Skip to content

fix(linter): fix generator '@nx/eslint:convert-to-flat-config' on win… #31043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025

Conversation

Teamop
Copy link
Contributor

@Teamop Teamop commented May 5, 2025

…dows

Current Behavior

When running nx g @nx/eslint:convert-to-flat-config on windows, the ignores path is not handled correctly. After converting, the path will have the additional /r

Expected Behavior

When running nx g @nx/eslint:convert-to-flat-config on windows, the ignores path should be correct.

Related Issue(s)

NA

@Teamop Teamop requested a review from a team as a code owner May 5, 2025 14:33
@Teamop Teamop requested a review from meeroslav May 5, 2025 14:33
Copy link

vercel bot commented May 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 30, 2025 2:15am

Copy link

nx-cloud bot commented May 5, 2025

View your CI Pipeline Execution ↗ for commit 5cbb2db.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 38m 34s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 15s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 3s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 2s View ↗
nx documentation ✅ Succeeded 2m 55s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-30 02:58:57 UTC

@FrozenPandaz FrozenPandaz added the priority: medium Medium Priority (not high, not low priority) label May 9, 2025
@Teamop Teamop force-pushed the fix-flat-convert branch 2 times, most recently from 5b68d4b to c6b3f92 Compare May 28, 2025 14:44
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to contribute!

We definitely need to handle those line endings better.

@Teamop Teamop force-pushed the fix-flat-convert branch from c6b3f92 to 5cbb2db Compare May 30, 2025 02:13
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@leosvelperez leosvelperez merged commit e249109 into nrwl:master May 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium Medium Priority (not high, not low priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants