ruff linted and ruff checked #8
Merged
Merged
Conversation
joanise
approved these changes
May 12, 2026
joanise
left a comment
joanise
left a comment
Member
There was a problem hiding this comment.
Beauteous! Love the change.
Now we just need prek to auto-apply these à la pre-commit. 😉
And boy, all sorts of refactoring could be done, but that's out of scope here so I won't spend too much time looking.
| max-parallel: 5 | ||
| matrix: | ||
| python: ["3.7", "3.12"] | ||
| python: ["3.10", "3.14"] |
Member
There was a problem hiding this comment.
Hum, why are we being so cheap here? We should do all five supported versions.
| if len(sys.argv) != 3: | ||
| sys.stderr.write("Usage: lines.py \n\ | ||
| sys.stderr.write( | ||
| "Usage: lines.py \n\ |
Member
There was a problem hiding this comment.
I guess we didn't know about dedent when we wrote this...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While doing plive work, I had to look at PortageTextProcessing and "had" to
ruff check --target-version py310 --output-format=concise bin/.Depends on #9