Skip to content

build: rebuild llhttp wasm with Node 24 toolchain#4905

Open
mcollina wants to merge 1 commit intomainfrom
chore/rebuild-llhttp-wasm-node24
Open

build: rebuild llhttp wasm with Node 24 toolchain#4905
mcollina wants to merge 1 commit intomainfrom
chore/rebuild-llhttp-wasm-node24

Conversation

@mcollina
Copy link
Member

Summary

  • rebuild the llhttp wasm artifacts with the Node 24-based wasm builder image
  • enable bulk-memory in the wasm-opt step so the newer clang/binaryen toolchain can optimize the generated module
  • refresh both standard and SIMD llhttp wasm outputs and their generated JS wrappers

Validation

  • rebuilt the llhttp wasm artifacts locally using the new builder image
  • verified the generated wrappers load successfully in Node
  • confirmed artifact sizes after rebuild:
    • llhttp.wasm: 53777 bytes
    • llhttp_simd.wasm: 53948 bytes

Notes

  • this PR does not include the pre-existing local change in test/client-wasm.js

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.90%. Comparing base (2885361) to head (3e38753).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4905      +/-   ##
==========================================
- Coverage   92.90%   92.90%   -0.01%     
==========================================
  Files         112      112              
  Lines       35638    35638              
==========================================
- Hits        33109    33108       -1     
- Misses       2529     2530       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants