Skip to content

test(fetch): add userinfo coverage for issue-4897 URLs#4901

Open
mcollina wants to merge 1 commit intomainfrom
fix/4897-userinfo-test-coverage
Open

test(fetch): add userinfo coverage for issue-4897 URLs#4901
mcollina wants to merge 1 commit intomainfrom
fix/4897-userinfo-test-coverage

Conversation

@mcollina
Copy link
Member

@mcollina mcollina commented Mar 16, 2026

Summary

  • add userinfo coverage ('' and user:pass@) to test/fetch/issue-4897.js as requested by @domenic
  • keep path extraction assertions for non-credentialed URLs
  • assert credentialed fetch URLs are rejected before dispatch with a TypeError mentioning credentials

Why

Follow-up to review nits on #4892 requesting extra coverage for URLs that include userinfo.

Testing

  • npx borp -p "test/fetch/issue-4897.js"
  • npx borp -p "test/websocket/issue-4889.js"

@mcollina mcollina requested a review from KhafraDev March 16, 2026 08:31
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.89%. Comparing base (4991f3e) to head (abeb7a0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4901      +/-   ##
==========================================
- Coverage   92.90%   92.89%   -0.01%     
==========================================
  Files         112      112              
  Lines       35638    35638              
==========================================
- Hits        33108    33106       -2     
- Misses       2530     2532       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants