Skip to content

src: swap dotenv and config file parsing order#63035

Open
marco-ippolito wants to merge 1 commit intonodejs:mainfrom
marco-ippolito:swap-env-from-file-config
Open

src: swap dotenv and config file parsing order#63035
marco-ippolito wants to merge 1 commit intonodejs:mainfrom
marco-ippolito:swap-env-from-file-config

Conversation

@marco-ippolito
Copy link
Copy Markdown
Member

Makes more sense that env variable override config file and not the opposite

Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. labels Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.63%. Comparing base (8173251) to head (e7ed568).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63035      +/-   ##
==========================================
- Coverage   91.49%   89.63%   -1.86%     
==========================================
  Files         358      708     +350     
  Lines      151574   220375   +68801     
  Branches    23921    42270   +18349     
==========================================
+ Hits       138679   197539   +58860     
- Misses      12619    14713    +2094     
- Partials      276     8123    +7847     
Files with missing lines Coverage Δ
src/node.cc 76.15% <100.00%> (ø)
src/node_dotenv.cc 84.72% <100.00%> (ø)

... and 469 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants