Skip to content

stream: copyedit webstreams/adapter.js#63034

Open
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:copyedit-adapters
Open

stream: copyedit webstreams/adapter.js#63034
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:copyedit-adapters

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Apr 29, 2026

  • Simplify ZLIB_FAILURES creation.
  • Cache cause.code in handleKnownInternalErrors in case of a getter.
  • Replace SafePromiseAll with SafePromiseAllReturnVoid to reduce the number of allocated promises.

- Simplify `ZLIB_FAILURES` creation.
- Cache `cause.code` in `handleKnownInternalErrors` in case of a getter.
- Replace `SafePromiseAll` with `SafePromiseAllReturnVoid` to reduce the
  number of allocated promises.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.64%. Comparing base (2a601eb) to head (11e2a51).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/webstreams/adapters.js 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63034      +/-   ##
==========================================
- Coverage   89.65%   89.64%   -0.01%     
==========================================
  Files         708      708              
  Lines      220374   220369       -5     
  Branches    42264    42275      +11     
==========================================
- Hits       197584   197560      -24     
- Misses      14656    14671      +15     
- Partials     8134     8138       +4     
Files with missing lines Coverage Δ
lib/internal/webstreams/adapters.js 86.54% <95.45%> (-0.07%) ⬇️

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. web streams

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants