src: add missing <cstdlib> for abort() declaration#63001
Open
ckerr wants to merge 1 commit intonodejs:mainfrom
Open
src: add missing <cstdlib> for abort() declaration#63001ckerr wants to merge 1 commit intonodejs:mainfrom
ckerr wants to merge 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
c++
Renegade334
reviewed
Apr 28, 2026
builtin_info.cc calls `abort()` but didn't call `<cstdlib>` to pick up its declaration. This has been working because `abort()` got picked up by a transitive declaration from another header, but it broke in Electron when we rolled our LLVM libc++ snapshot from commit 8e870711923 to 9aaa9a2ee87. Signed-off-by: Charles Kerr <charles@charleskerr.com>
ckerr
force-pushed
the
fix/missing-includes-builtin_info.cc
branch
from
1f578c7 to
d5ad888
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63001 +/- ##
==========================================
- Coverage 91.47% 89.65% -1.83%
==========================================
Files 357 707 +350
Lines 150883 219509 +68626
Branches 23778 42084 +18306
==========================================
+ Hits 138026 196809 +58783
- Misses 12582 14588 +2006
- Partials 275 8112 +7837
🚀 New features to boost your workflow:
|
targos
approved these changes
Apr 28, 2026
richardlau
approved these changes
Apr 28, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
RaisinTen
approved these changes
Apr 28, 2026
addaleax
reviewed
Apr 28, 2026
lpinca
approved these changes
Apr 28, 2026
Collaborator
Collaborator
RaisinTen
added
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR to add
#include <cstdlib>insrc/builtin_info.ccbecause it usesabort().This has been compiling up until now because
abort()got picked up by a transitive declaration from another header. I noticed this when it broke in Electron today when we rolled our LLVM libc++ snapshot. Looks like LLVM libc++ cleaned up the transitive include that made this work for Electron before.