util: create hex style cache and fast path#62999
util: create hex style cache and fast path#62999araujogui wants to merge 2 commits intonodejs:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves util.styleText() performance for hex colors by introducing a cached hex-style lookup and a fast path for the common case where validateStream: false.
Changes:
- Add a module-level
hexStyleCacheand helper (getHexStyle) to memoize computed ANSI sequences for#RGB/#RRGGBB. - Reuse a shared close sequence constant for 24-bit foreground colors (
\u001b[39m) and integrate hex handling into thevalidateStream: falsefast path. - Refactor hex handling in the main formatting loop to use cached sequences instead of re-parsing on every call.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const hexStyleCache = { __proto__: null }; | ||
|
|
There was a problem hiding this comment.
isn't the maximum possible permutations here 16,781,312 - is the memory size of 17 million key/value pairs a massive concern?
There was a problem hiding this comment.
Great point, altought a LRU doesn't seem a bad idea
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62999 +/- ##
==========================================
- Coverage 89.67% 89.57% -0.11%
==========================================
Files 707 708 +1
Lines 219509 220246 +737
Branches 42093 42188 +95
==========================================
+ Hits 196851 197286 +435
- Misses 14551 14828 +277
- Partials 8107 8132 +25
🚀 New features to boost your workflow:
|
| const kHexCloseSeq = kEscape + '39' + kEscapeEnd; | ||
|
|
||
| let styleCache; | ||
| const hexStyleCache = { __proto__: null }; |
There was a problem hiding this comment.
I note the benchmarks are all repeating the same lookup – I imagine that using a plain object as the map here could end up deoptimising if the cache miss rate is high, eg. colours being randomised by the user? Appreciate this is probably quite niche in reality, but might be worth a benchmark case to see how something like a SafeMap would compare.
Improve
styleTextperformance by caching and fast-pathBenchmark