Skip to content

child_process: move _channel to end-of-life #58527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2025
Merged

child_process: move _channel to end-of-life #58527

merged 2 commits into from
Jun 2, 2025
+5 −20

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented May 31, 2025

The ._channel property has been deprecated for many years now. It's time to remove it.

@jasnell
child_process: move _channel to end-of-life
a16ce0e 
The `._channel` property has been deprecated for many years
now. It's time to remove it.
@jasnell jasnell requested review from mcollina, anonrig and cjihrig May 31, 2025 16:16
@jasnell jasnell added child_process Issues and PRs related to the child_process subsystem. semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels May 31, 2025
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 31, 2025
jasnell
jasnell commented May 31, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented May 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (968e2f4) to head (e248f99).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58527      +/-   ##
==========================================
+ Coverage   90.21%   90.24%   +0.02%     
==========================================
  Files         635      635              
  Lines      187580   187564      -16     
  Branches    36853    36853              
==========================================
+ Hits       169231   169272      +41     
+ Misses      11108    11052      -56     
+ Partials     7241     7240       -1
Files with missing lines Coverage Δ
lib/internal/child_process.js 95.08% <100.00%> (+0.01%) ⬆️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 31, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/67206/ 💛

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 31, 2025
@jasnell jasnell added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 1, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 2, 2025
@nodejs-github-bot nodejs-github-bot merged commit df16f0f into nodejs:main Jun 2, 2025
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in df16f0f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mertcanaltin mertcanaltin mertcanaltin approved these changes

@mcollina mcollina Awaiting requested review from mcollina

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. child_process Issues and PRs related to the child_process subsystem. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. deprecations Issues and PRs related to deprecations. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jasnell @nodejs-github-bot @lpinca @anonrig @targos @cjihrig @mertcanaltin