child_process: options.shell
validation
#58525
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on an original PR at #54623, with modifications based on #56761 (comment).
child_process: validate exec's
options.shell
as stringWhile execFile and spawn perform validation on
options.shell
, exec just silently ignores invalid values without raising any error. This changes that behaviour to an explicit validation.child_process: deprecate passing
options.shell
as empty stringPassing
{ shell: '' }
to the process creation functions should never be intentional, and doing so has some funky behaviour:{ shell: false }
command
as a file pathThis adds a pending deprecation for this case.