Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Node.js references in the infra automation to use Node.js 22 (per #4272), covering both host provisioning (NodeSource APT repos) and container images used by the metrics tooling.
Changes:
- Bump multiple NodeSource APT repository entries to
node_22.x. - Update metrics-related Dockerfiles from
node:20-slimtonode:22-slim. - Update Jenkins workspace / GitHub bot roles to target NodeSource Node 22 repo.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| ansible/roles/unofficial-builds/tasks/main.yml | Updates NodeSource APT repo from Node 16 to Node 22 for the unofficial-builds host role. |
| ansible/roles/metrics/tasks/main.yml | Updates NodeSource APT repo from Node 12 to Node 22 for the metrics host role. |
| ansible/roles/metrics/files/summaries/Dockerfile | Bumps base image to Node 22 slim. |
| ansible/roles/metrics/files/process-cloudflare/Dockerfile | Bumps base image to Node 22 slim. |
| ansible/roles/metrics/files/index-generator/Dockerfile | Bumps base image to Node 22 slim. |
| ansible/roles/jenkins-workspace/tasks/main.yml | Updates NodeSource APT repo to Node 22 for Jenkins workspace hosts. |
| ansible/roles/github-bot/tasks/main.yml | Updates NodeSource APT repo to Node 22 for the GitHub bot host. |
| ansible/playbooks/create-webhost.yml | Updates NodeSource repo entries for the webhost provisioning playbook to Node 22. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
36
to
+43
| - name: Bootstrap | Add nodesource signing key | ||
| ansible.builtin.get_url: | ||
| dest: /etc/apt/keyrings/nodesource-repo.gpg.asc | ||
| url: https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | ||
|
|
||
| - name: Bootstrap | Add nodesource repo | ||
| apt_repository: | ||
| repo: deb [arch=amd64 signed-by=/etc/apt/keyrings/nodesource-repo.gpg.asc] https://deb.nodesource.com/node_20.x nodistro main | ||
| repo: deb [arch=amd64 signed-by=/etc/apt/keyrings/nodesource-repo.gpg.asc] https://deb.nodesource.com/node_22.x nodistro main |
Comment on lines
135
to
+142
| - name: Add nodesource signing key | ||
| ansible.builtin.get_url: | ||
| dest: /etc/apt/keyrings/nodesource-repo.gpg.asc | ||
| url: https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | ||
|
|
||
| - name: Add nodesource 20 repo | ||
| - name: Add nodesource 22 repo | ||
| apt_repository: | ||
| repo: deb [arch=amd64 signed-by=/etc/apt/keyrings/nodesource-repo.gpg.asc] https://deb.nodesource.com/node_20.x nodistro main | ||
| repo: deb [arch=amd64 signed-by=/etc/apt/keyrings/nodesource-repo.gpg.asc] https://deb.nodesource.com/node_22.x nodistro main |
| - name: Bootstrap | Add nodesource repo | ||
| ansible.builtin.apt_repository: | ||
| repo: "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_16.x nodistro main" | ||
| repo: "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_22.x nodistro main" |
Comment on lines
3
to
11
| - name: Bootstrap | Add nodesource signing key | ||
| apt_key: | ||
| url: https://deb.nodesource.com/gpgkey/nodesource.gpg.key | ||
| state: present | ||
|
|
||
| - name: Bootstrap | Add nodesource repo | ||
| apt_repository: | ||
| repo: deb https://deb.nodesource.com/node_12.x bionic main | ||
| repo: deb https://deb.nodesource.com/node_22.x nodistro main | ||
| state: present |
| - deb https://deb.nodesource.com/node_6.x xenial main | ||
| - deb-src https://deb.nodesource.com/node_6.x xenial main | ||
| - deb https://deb.nodesource.com/node_22.x nodistro main | ||
| - deb-src https://deb.nodesource.com/node_22.x nodistro main |
Comment on lines
+45
to
+46
| - deb https://deb.nodesource.com/node_22.x nodistro main | ||
| - deb-src https://deb.nodesource.com/node_22.x nodistro main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4272
I wasn't 100% sure which one of these were legacy for a reason, so I updated all of them, but if something breaks, please feel free to modify this PR as needed.