Skip to content

chore(ci): improve ci #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 27, 2025
Merged

chore(ci): improve ci #281

merged 5 commits into from
May 27, 2025

Conversation

avivkeller
Copy link
Member

This PR makes a few changes to our CI:

  1. Use prettier --check, so it'll actually throw when formatting doesn't match
  2. Use codecov for test results and coverage, like in the website repo

@avivkeller avivkeller requested a review from a team as a code owner May 27, 2025 13:24
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

avivkeller and others added 5 commits May 27, 2025 15:57
Co-authored-by: Sebastian Beltran <[email protected]>
Co-authored-by: Sebastian Beltran <[email protected]>
Co-authored-by: Sebastian Beltran <[email protected]>
@avivkeller avivkeller merged commit 32834c4 into main May 27, 2025
7 checks passed
@avivkeller avivkeller deleted the chore/ci/improve branch May 27, 2025 19:58
@avivkeller
Copy link
Member Author

@flakey5 Per what you said on Slack, can we add CI / Lint & Format and CI / Test & Coverage as required checks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants