-
Notifications
You must be signed in to change notification settings - Fork 10
feat(jsx): add jsx
generator
#273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting basic, don't miss to add some test
I'm working on skipping the MDX and going to straight to JSX, so I'll add lots of tests when that's started |
60922b4
to
d2bd5f4
Compare
This uses pnpm for now, see #236 for reference. If we do adopt pnpm, it would be a seperate PR, this is just for development. |
8020c31
to
60e76e5
Compare
ef09a04
to
a002cc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a final round of comments; After that LGTM. But only approving the PR once the git-deps issue is addressed (either by the upstream npm publish or incorporating git-deps on @.pkgjs/@.nodejs)
maybe add little bit more test |
This review was specific to a security concern, which has since been resolved.
26b46c4
to
e109999
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
==========================================
- Coverage 91.88% 90.55% -1.34%
==========================================
Files 56 63 +7
Lines 4142 4754 +612
Branches 174 191 +17
==========================================
+ Hits 3806 4305 +499
- Misses 334 446 +112
- Partials 2 3 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
22a9dc7
to
3e302a1
Compare
3e302a1
to
b89fe19
Compare
This PR introduces a
jsx
generator that transforms Markdown AST and metadata entries into a JSX (recma
) AST (with a root ofProgram
), which can then be compiled by thereact-web
generator from #7.The JSX generator produces AST that assumes that all the components in #10 (comment) have been implemented.
As of 5/26/25, the generated AST is: https://aviv.sh/hostables/nodejs/1748274862-jsx-ast.json