Skip to content

feat: create metadata entries generator #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 3, 2025

Conversation

araujogui
Copy link
Member

Description

Creates metadata entries generator

Related Issues

Fixes #271

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

@araujogui araujogui changed the title Refactor parsers feat: create metadata entries generator May 14, 2025
@araujogui
Copy link
Member Author

araujogui commented May 15, 2025

Blocking this until #275 is merged.

@araujogui araujogui marked this pull request as ready for review May 22, 2025 16:44
@araujogui araujogui requested a review from a team as a code owner May 22, 2025 16:44
@ovflowd
Copy link
Member

ovflowd commented May 23, 2025

@araujogui I saw there is a blocked label, could you elaborate what's blocked?

@araujogui
Copy link
Member Author

@araujogui I saw there is a blocked label, could you elaborate what's blocked?

The current linter relies on metadata entries, which are no longer easily available because it's now a generator. I’ve blocked this until #275 is merged, as it removes the linter's dependency on metadata.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.58%. Comparing base (97b3495) to head (fda93a1).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   90.58%   90.58%           
=======================================
  Files          63       63           
  Lines        4767     4767           
  Branches      191      191           
=======================================
  Hits         4318     4318           
  Misses        446      446           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@araujogui araujogui removed the blocked label May 28, 2025
@araujogui
Copy link
Member Author

@nodejs/web-infra this is ready for reviews

Copy link
Member

@canerakdas canerakdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just small nits for the making consistent on the type definitions, LGTM!

@araujogui araujogui enabled auto-merge (squash) June 3, 2025 21:24
@araujogui araujogui merged commit 702cb43 into nodejs:main Jun 3, 2025
7 checks passed
@@ -26,7 +26,7 @@ export default {

description: 'Generates the legacy version of the JSON API docs.',

dependsOn: 'ast',
dependsOn: 'metadata',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we renaming this to metadata just OOC?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create metadata entries generator
5 participants