-
Notifications
You must be signed in to change notification settings - Fork 9
feat: create metadata entries generator #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Blocking this until #275 is merged. |
f6ba0c8
to
37a572d
Compare
@araujogui I saw there is a blocked label, could you elaborate what's blocked? |
The current linter relies on metadata entries, which are no longer easily available because it's now a generator. I’ve blocked this until #275 is merged, as it removes the linter's dependency on metadata. |
37a572d
to
2f6cf99
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
=======================================
Coverage 90.58% 90.58%
=======================================
Files 63 63
Lines 4767 4767
Branches 191 191
=======================================
Hits 4318 4318
Misses 446 446
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@nodejs/web-infra this is ready for reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just small nits for the making consistent on the type definitions, LGTM!
400912c
to
a81d6d6
Compare
@@ -26,7 +26,7 @@ export default { | |||
|
|||
description: 'Generates the legacy version of the JSON API docs.', | |||
|
|||
dependsOn: 'ast', | |||
dependsOn: 'metadata', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we renaming this to metadata
just OOC?
Description
Creates metadata entries generator
Related Issues
Fixes #271
Check List
node --run test
and all tests passed.node --run format
&node --run lint
.