zellij: make ribbon_unselected background darker and base lighter#2257
Open
muni-corn wants to merge 1 commit intonix-community:masterfrom
Open
zellij: make ribbon_unselected background darker and base lighter#2257muni-corn wants to merge 1 commit intonix-community:masterfrom
muni-corn wants to merge 1 commit intonix-community:masterfrom
Conversation
0xda157
requested changes
Apr 3, 2026
Contributor
0xda157
left a comment
There was a problem hiding this comment.
this change causes the ribbon_unselected background to not contrast enough with the base when using catppuccin mocha for example (as tested in testbed:zellij:dark). additionally, when using the official zellij catppuccin mocha theme as an example, stylix's current implementation matches their implementation. ideally stylix would follow the upstream styling when possible.
6334d0c to
4602601
Compare
4602601 to
b95fbd2
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #143.
This PR modifies the colors of unselected ribbons so that they're more in harmony with the rest of the Zellij stylix theme.
Comparison (old on top, new on bottom):