Skip to content

zellij: make ribbon_unselected background darker and base lighter#2257

Open
muni-corn wants to merge 1 commit intonix-community:masterfrom
muni-corn:fix-zellij-bars
Open

zellij: make ribbon_unselected background darker and base lighter#2257
muni-corn wants to merge 1 commit intonix-community:masterfrom
muni-corn:fix-zellij-bars

Conversation

@muni-corn
Copy link
Copy Markdown

Fixes #143.

This PR modifies the colors of unselected ribbons so that they're more in harmony with the rest of the Zellij stylix theme.

Comparison (old on top, new on bottom):

image

@stylix-automation stylix-automation bot added topic: home-manager Home Manager target topic: modules /modules/ subsystem labels Mar 28, 2026
@stylix-automation stylix-automation bot requested a review from trueNAHO March 28, 2026 01:37
Copy link
Copy Markdown
Contributor

@0xda157 0xda157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change causes the ribbon_unselected background to not contrast enough with the base when using catppuccin mocha for example (as tested in testbed:zellij:dark). additionally, when using the official zellij catppuccin mocha theme as an example, stylix's current implementation matches their implementation. ideally stylix would follow the upstream styling when possible.

@muni-corn
Copy link
Copy Markdown
Author

heard! how does this look? i simply bumped base04 to base05 for base.

image

note: i don't believe this PR even addresses the linked issue as well. i didn't grasp what the issue really was. the true issue deals with a limitation with base16 if i understand correctly.

and although i personally like the looks of zellij with this PR, that makes it a subjective thing that i can easily overwrite in my own config 😁

getting this PR merged is not a hill i will die on, so i'll leave it up to the community and maintainers since i don't believe it really fixes any actual issues 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: home-manager Home Manager target topic: modules /modules/ subsystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zellij: bars are too bright

2 participants