firefox: support Glide derivative#2240
firefox: support Glide derivative#2240zzzealed wants to merge 4 commits intonix-community:masterfrom
Conversation
There was a problem hiding this comment.
CI is currently failing because lib.maintainers.zzzealed and glide-browser are undefined. If these are recent upstream additions, this PR requires #2180 to be merged first.
- Each commit in this PR is suitable for backport to the current stable branch
Are the necessary upstream patches available in our release-25.11 branch?
I hope I added everything correctly, as this is my first time making a contribution.
LGTM, except for one nitpick. I will also test this PR in a testbed once CI is working again.
Yeah so I removed myself as maintainer since I'm not in maintainer-list.nix. I hope this is fine.
Yes it look's to me like |
|
CI failures seem to be unrelated to this PR's changes, could you force push to trigger a re-run? also ideally a testbed would be added before merging. |
b8adbe5 to
bd2fac8
Compare
Sure I can do that. As I said Glide isn't in Nixpkgs but I could just add Glide's input in Does this approach make sense? |
Hello and thanks for your work on Stylix :)
I added Glide to the Firefox (and derivatives)-module, since Glide now has a Home Manager-module made with
mkFirefoxModule. This means it should be compatible with the same options as the other derivatives.I tested this myself and can confirm that the options looks to be working.
I hope I added everything correctly, as this is my first time making a contribution. Please do not hesitate to leave feedback or request changes.