lib/plugins: add optional setup plumbing; add public callSetup override#4258
Open
khaneliman wants to merge 5 commits intonix-community:mainfrom
Open
lib/plugins: add optional setup plumbing; add public callSetup override#4258khaneliman wants to merge 5 commits intonix-community:mainfrom
khaneliman wants to merge 5 commits intonix-community:mainfrom
Conversation
Expose a user-facing callSetup option for mkNeovimPlugin users while keeping plugin defaults internal. Preserve optional setup semantics, document the override, and cover the new behavior with unit and failure tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3959
Adding the optional
callSetupfunctionality to allow us to respect modern neovim plugin direction of migrating away from explicit setup calls. Added an internal mechanism that we can use on plugins we know support it, while giving a public api option to allow a user to override the setup call themself.Have a fixup commit related to the discussion about whether we should be over protective or allow advanced usage.