ci: lix parse; treewide: fix incorrect string escapes#4253
Merged
khaneliman merged 3 commits intonix-community:mainfrom Apr 22, 2026
Merged
ci: lix parse; treewide: fix incorrect string escapes#4253khaneliman merged 3 commits intonix-community:mainfrom
khaneliman merged 3 commits intonix-community:mainfrom
Conversation
Done with help of lix parsing for warnings.
Member
MattSturgeon
left a comment
MattSturgeon
left a comment
There was a problem hiding this comment.
Couple nits w.r.t. nix/shell variable hygiene. Otherwise sgtm.
Thanks for putting this together!
| }; | ||
| fileEncoding = "utf8"; | ||
| meta = "$\{version} $\{language} $\{encoding}"; | ||
| meta = "\${version} \${language} \${encoding}"; |
Member
There was a problem hiding this comment.
I wonder why we had so many $\{foo}s?
Contributor
Author
There was a problem hiding this comment.
Harder to spot just trying to get lsp / eval happy
| shell: bash | ||
|
|
||
| jobs: | ||
| treefmt: |
Member
There was a problem hiding this comment.
This job should probably be renamed now.
Maybe lint is ok, but that'll show up in the UI as lint / lint (pull_request).
Member
There was a problem hiding this comment.
This makes me think... Would nix-instantiate --parse make sense as a treefmt step? We'd need to wrap it in a treefmt-compliant tool of course, and have lix+nix permutations still. Maybe an idea for another day.
Co-authored-by: Wolfgang Walther <walther@technowledgy.de> Co-authored-by: piegames <git@piegames.de>
Replace the copied wrapper form with the final Vim regex string and update the test fixture to match. This preserves upstream regex behavior while still avoiding the broken Nix string escape warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done with help of lix parsing for warnings.
Closes #4251
Related nix-community/home-manager#9150 NixOS/nixpkgs#511836