Conversation
Hullo 👋 @pi0 I ran your skills through `tessl skill review` at work and found some targeted improvements. Here's the full before/after: | Skill | Before | After | Change | |-------|--------|-------|--------| | nitro | 43% | 94% | +51% | | update-deps | 0% | 89% | +89% | <details> <summary>Changes made</summary> **nitro** (`skills/nitro/SKILL.md`) - Expanded frontmatter description with specific capabilities (API routes, middleware, server plugins, scheduled tasks, WebSocket handlers) and deployment targets (Vercel, Cloudflare Workers, Deno, Bun) - Added explicit "Use when..." clause with natural trigger terms for better skill selection - Added quick-reference section with concrete, executable code examples (creating an API route, running dev server, building, deploying with presets) - Preserved the existing `@docs/TOC.md` reference and doc fallback URL **update-deps** (`.agents/skills/update-deps/SKILL.md`) - Added YAML frontmatter with `name` and `description` fields (was missing entirely — caused 0% score due to validation failure) - Added "Use when..." clause covering common trigger scenarios (upgrading packages, outdated deps, version conflicts, dependency-update PRs) - Fixed inconsistent step numbering (was missing step 8, jumped from 7 to 9) - Added explicit CHECKPOINT validation gates between critical steps - Trimmed redundant introductory text </details> Honest disclosure — I work at @tesslio where we build tooling around skills like these. Not a pitch - just saw room for improvement and wanted to contribute. Want to self-improve your skills? Just point your agent (Claude Code, Codex, etc.) at [this Tessl guide](https://docs.tessl.io/evaluate/optimize-a-skill-using-best-practices) and ask it to optimize your skill. Ping me - [@popey](https://github.com/popey) - if you hit any snags. Thanks in advance 🙏
|
@popey is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughTwo skill documentation files are enhanced with expanded content: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.Change the |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
.agents/skills/update-deps/SKILL.md (2)
50-58:⚠️ Potential issue | 🟡 MinorFix
sed -ifor cross-platform compatibility.The
sed -icommand syntax differs between GNU sed (Linux) and BSD sed (macOS). On macOS,sed -irequires an empty string argument:sed -i '' .... This will cause the script to fail on macOS systems.🔧 Proposed fix for portability
# Revert nitro link references back to latest in all modified package.json files git diff --name-only | grep 'package.json$' | while read file; do if grep -q '"nitro": "link:' "$file" 2>/dev/null; then - sed -i 's/"nitro": "link:[^"]*"/"nitro": "latest"/g' "$file" + sed -i.bak 's/"nitro": "link:[^"]*"/"nitro": "latest"/g' "$file" && rm "${file}.bak" echo "Fixed: $file" fi doneThis approach creates a
.bakfile and immediately removes it, which works identically on both GNU and BSD sed.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.agents/skills/update-deps/SKILL.md around lines 50 - 58, The sed -i usage in the SKILL.md script loop is not cross-platform; update the command used inside the while loop (the sed invocation that replaces the "nitro" link) to use a portable pattern that creates a backup and then removes it (e.g., use sed -i.bak ... and then rm "$file.bak"), so macOS BSD sed and GNU sed both work; adjust the block that checks grep -q '"nitro": "link:' "$file" and the sed replacement invocation accordingly and ensure the script echoes "Fixed: $file" only after successful replacement.
123-130:⚠️ Potential issue | 🟡 MinorClarify contradictory guidance on typecheck errors.
Line 130 instructs to "Ignore errors, only report them in the end," which is contradictory and unclear. Should errors be fixed or just reported? This conflicts with the earlier instruction to "Fix issues manually" (line 128). Based on learnings,
pnpm typecheckshould be run after making changes, but the guidance on handling failures is ambiguous.Consider clarifying the intent:
- If typecheck errors should block the process: "Re-run
pnpm typecheckand ensure all type errors are resolved."- If typecheck errors are informational: "Re-run
pnpm typecheckto identify type issues. Document any unresolved errors in the summary."Based on learnings: Run
pnpm formatandpnpm typecheckafter making changes.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.agents/skills/update-deps/SKILL.md around lines 123 - 130, Update the "9. Fix Remaining Issues" section to remove the contradiction between step 2 ("Fix issues manually") and step 4 ("Ignore errors, only report them in the end") by clarifying whether typecheck errors must be fixed or may be reported; edit steps 3–4 in the "9. Fix Remaining Issues" block to one clear policy: either replace step 4 with "Re-run `pnpm typecheck` and ensure all type errors are resolved" if type errors should block the process, or replace it with "Re-run `pnpm typecheck` to identify type issues and document any unresolved errors in the summary" if they are informational, and ensure the final sentence explicitly instructs to run `pnpm format` and then `pnpm typecheck` after making changes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@skills/nitro/SKILL.md`:
- Around line 17-23: In the Common Tasks section replace the deprecated "npx
nitropack" invocations with the updated Nitro v3 CLI: change the snippet that
runs the dev server from "npx nitropack" to "npx nitro dev", change the build
command from "npx nitropack" to "npx nitro build", and change the Cloudflare
Pages build invocation from "npx nitropack build" to
"NITRO_PRESET=cloudflare-pages npx nitro build"; locate the three occurrences by
searching for the string "npx nitropack" in the Common Tasks section and update
them to match the Quick Reference examples.
---
Outside diff comments:
In @.agents/skills/update-deps/SKILL.md:
- Around line 50-58: The sed -i usage in the SKILL.md script loop is not
cross-platform; update the command used inside the while loop (the sed
invocation that replaces the "nitro" link) to use a portable pattern that
creates a backup and then removes it (e.g., use sed -i.bak ... and then rm
"$file.bak"), so macOS BSD sed and GNU sed both work; adjust the block that
checks grep -q '"nitro": "link:' "$file" and the sed replacement invocation
accordingly and ensure the script echoes "Fixed: $file" only after successful
replacement.
- Around line 123-130: Update the "9. Fix Remaining Issues" section to remove
the contradiction between step 2 ("Fix issues manually") and step 4 ("Ignore
errors, only report them in the end") by clarifying whether typecheck errors
must be fixed or may be reported; edit steps 3–4 in the "9. Fix Remaining
Issues" block to one clear policy: either replace step 4 with "Re-run `pnpm
typecheck` and ensure all type errors are resolved" if type errors should block
the process, or replace it with "Re-run `pnpm typecheck` to identify type issues
and document any unresolved errors in the summary" if they are informational,
and ensure the final sentence explicitly instructs to run `pnpm format` and then
`pnpm typecheck` after making changes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 80b988a5-5b3b-4110-9442-daed4127803a
📒 Files selected for processing (2)
.agents/skills/update-deps/SKILL.mdskills/nitro/SKILL.md
| ```bash | ||
| # Browse docs by topic | ||
| npx nitro docs --page /docs/routing | ||
|
|
||
| # Full docs index | ||
| npx nitro docs | ||
| ``` |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check which Nitro CLI commands are documented and valid
# Search for CLI command references in the repository
echo "=== Searching for nitro CLI command patterns ==="
rg -n "npx nitro(?:pack)?\b" --type md -C2
echo -e "\n=== Checking package.json for bin entries ==="
fd -e json "^package\.json$" --exec jq -r 'select(.bin != null) | "File: \(.name // "unknown")\nBin entries: \(.bin)"' 2>/dev/nullRepository: nitrojs/nitro
Length of output: 1454
🏁 Script executed:
# Check if nitropack is a separate dependency or an old name
rg "nitropack" --type json -A 2 -B 2
# Check the package.json to see all dependencies
fd -e json "^package\.json$" -x head -50 {}
# Look for any documentation or comments about nitropack
rg "nitropack" --type md -A 2 -B 2 | head -50Repository: nitrojs/nitro
Length of output: 12373
Update CLI commands: change npx nitropack to npx nitro in Common Tasks section.
Lines 43, 49, and 55 use npx nitropack, but Nitro v3 renamed the package from nitropack (v2) to nitro (v3). These should be changed to npx nitro dev, npx nitro build, and NITRO_PRESET=cloudflare-pages npx nitro build respectively, to match the Quick Reference section (lines 19, 22) and align with the current CLI.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@skills/nitro/SKILL.md` around lines 17 - 23, In the Common Tasks section
replace the deprecated "npx nitropack" invocations with the updated Nitro v3
CLI: change the snippet that runs the dev server from "npx nitropack" to "npx
nitro dev", change the build command from "npx nitropack" to "npx nitro build",
and change the Cloudflare Pages build invocation from "npx nitropack build" to
"NITRO_PRESET=cloudflare-pages npx nitro build"; locate the three occurrences by
searching for the string "npx nitropack" in the Common Tasks section and update
them to match the Quick Reference examples.
| ### Run the dev server | ||
|
|
||
| ```bash | ||
| npx nitropack dev |
There was a problem hiding this comment.
Nitro v3 command is nitro not nitropack
| Add a file under `server/api/` or `routes/`: | ||
|
|
||
| ```ts | ||
| // server/api/hello.get.ts |
There was a problem hiding this comment.
Nitro v3 needs explicit import defineHandler
Hullo 👋 @pi0
🔗 Linked issue
Fixes #4115 4115
I ran your skills through
tessl skill reviewat work and found some targeted improvements.Here's the full before/after in text form:
📚 Description
Changes made
nitro (
skills/nitro/SKILL.md)@docs/TOC.mdreference and doc fallback URLupdate-deps (
.agents/skills/update-deps/SKILL.md)nameanddescriptionfields (was missing entirely — caused 0% score due to validation failure)❓ Type of change
(I ticked "Documentation" because conceptually skills are docs, just not for you, but for agents. In case anyone is feeling picky) :D
📝 Checklist
Want to self-improve your skills? Just point your agent (Claude Code, Codex, etc.) at this Tessl guide and ask it to optimize your skill. Ping me - @popey - if you hit any snags.