replace escape-string-regexp with tiny-escape#4109
replace escape-string-regexp with tiny-escape#4109ofershap wants to merge 1 commit intonitrojs:mainfrom
Conversation
Made-with: Cursor
|
@ofershap is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughReplaced the "escape-string-regexp" dependency with "tiny-escape" in both package.json and the corresponding import statement in src/config/resolvers/imports.ts. No functional logic or public API changes detected. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can customize the tone of the review comments and chat replies.Configure the |
|
nice find! We actually have builtin utils wondering might be best to just refactor and use them https://github.com/nitrojs/nitro/blob/main/src/utils/regex.ts |
tiny-escape has the same API as escape-string-regexp. Ships ESM + CJS with built-in TypeScript types. 192 bytes gzipped, zero deps.
https://npmgraph.js.org/?q=tiny-escape