docs(routing): update error handling description #3564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
I believe the above excerpt is no longer applicable due to the changes from #3002.
It was true when the response still uses a util function called
isJsonRequestand it has a specific check forevent.path.startsWith("/api/")to make sure routes in that path will return JSON:nitro/src/runtime/internal/error/utils.ts
Lines 11 to 24 in e8d6099
but as it was removed and #3002 specifically split the error handler into dev and prod handlers, I've opted to update the docs based on the new error handling changes.
That being said, should the following existing sentence:
be removed since it might be redundant now? or at least the
User-Agentpart might not really work, assuming if I didn't misunderstand the new error handling logic of course.Update: in hindsight maybe this PR should've targeted v2 instead of v3 since #3002 was merged into v2. Do let me know if you'd prefer that.
π Checklist