Open
Conversation
- Added properties `azureProxy`, `azureEndpoint`, `azureApiKey`, and `openAIEndpoint` to the `VectorStorage` class - Modified the constructor to accept these new options - UpdatedembedTexts` function to use the Azure endpoint and API key if provided, or fallback to the OpenAI API key - Adjusted the code to handle the different scenarios for API key and endpoint - Updated the `IVSOptions` interface to include the new options
- The clearAll method clears all documents in the clearing the documents, the updated storage is saved to IndexDB.
- The clearAll method clears all documents in the clearing the documents, the updated storage is saved to IndexDB.
- Implemented clearMatching method in VectorStorage class, which removes matching documents based on filter options
…ments. - Added new method `retainMatching to the VectorStorage class. - This method filters the documents based on the given filter options. - The filtered documents are stored in the `documents` property. - After filtering, documents are saved to the index DB storage.
…the matchesCriteria function to handle arrays in the criteria metadata - If the criteria metadata value is an array, it checks if the document metadata value is included in the array; otherwise, it checks for strict equality - This allows for more flexible filtering options for documents based on metadata
dllz
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Tested these changes locally and they work well. I would merge @nitaiaharoni1
|
This is just what I want. |
|
Great job, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks very much for the great package.
I want to use this in an enterprise setting, in the browser, using our AzureOpenAI endpoint, without exposing our API key.
azureProxy,azureEndpoint,azureApiKey, andopenAIEndpointto theVectorStorageclassembedTextsfunction to use the Azure endpoint and API key if provided, or fallback to the OpenAI API keyIVSOptionsinterface to include the new options