Implement PreparedRenderer API to make it possible to render multiple…#3276
Open
koluch wants to merge 1 commit intoniklasvh:masterfrom
Open
Implement PreparedRenderer API to make it possible to render multiple…#3276koluch wants to merge 1 commit intoniklasvh:masterfrom
koluch wants to merge 1 commit intoniklasvh:masterfrom
Conversation
… elements without cloning document every time; added a demo page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I implemented a function "makeRenderer", which create an object with cloned document, and provides a function "renderElements" to render multiple canvas elements
I also changed "DocumentCloner" class a bit, to make it work without provided "referenceElement"
We faced an issue when original document cloning takes a lot of time, and we need to render multiple elements on the page to the canvas.
Test plan (required)
I added a new demo page "demo_make_renderer"