fix: multi-line inline block with background color; support CSS filter#3251
Open
Ovilia wants to merge 3 commits intoniklasvh:masterfrom
Open
fix: multi-line inline block with background color; support CSS filter#3251Ovilia wants to merge 3 commits intoniklasvh:masterfrom
Ovilia wants to merge 3 commits intoniklasvh:masterfrom
Conversation
|
However, this test case is failing - there's an issue with the textBounds calculation: The textBounds calculation has issues with this complex nested structure. |
Author
Thanks for your feedback. I don't think this is a problem brought by this PR because I checked the result with the currect code before this PR, it behaves the same. So I think this should be relevant to my changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes/implements the following bugs/features
Explain the motivation for making this change. What existing problem does the pull request solve?
Bug 1: multi-line inline block with background color
Before:
The background of multi-line inline element has wrong position, and it covers other text.
After:
Bug 2: CSS filter has no effect
Before:
CSS
filterwas not supported.After:
Test plan (required)
Code formatting
Please make sure that code adheres to the project code formatting. Running
npm run formatwill automatically format your code correctly.Closing issues
Fixes #