QuickJS: using JS_AddIntrinsicBigInt() if detected.#870
Merged
VadimZhestikov merged 1 commit intonginx:masterfrom Mar 20, 2025
Merged
QuickJS: using JS_AddIntrinsicBigInt() if detected.#870VadimZhestikov merged 1 commit intonginx:masterfrom
VadimZhestikov merged 1 commit intonginx:masterfrom
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
VadimZhestikov
force-pushed
the
JS_AddIntrinsicBigInt
branch
from
c9bce30 to
0586245
Compare
VadimZhestikov
changed the title
VadimZhestikov
force-pushed
the
JS_AddIntrinsicBigInt
branch
from
20c2dc6 to
b04d84e
Compare
xeioex
previously requested changes
Mar 20, 2025
Contributor
xeioex
left a comment
xeioex
left a comment
There was a problem hiding this comment.
Suggested commit log:
QuickJS: using JS_AddIntrinsicBigInt() if detected.
Otherwise looks good.
VadimZhestikov
force-pushed
the
JS_AddIntrinsicBigInt
branch
from
b04d84e to
3421a5f
Compare
VadimZhestikov
changed the title
xeioex
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In quickjs JS_AddIntrinsicBigInt() is moved from public API to JS_AddIntrinsicBaseObjects():
commit 6d6893bfa3d383d4952b67954003800aba1f4be8
Author: Fabrice Bellard fabrice@bellard.org
Date: Wed Mar 19 12:33:54 2025 +0100