Skip to content

Fix port binding with reduced privileges (#3574) #3590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025

Conversation

sjberman
Copy link
Collaborator

@sjberman sjberman commented Jul 3, 2025

Cherrypick of #3574

Problem: The nginx deployment was using extra privileges in order to bind to privileged ports (<1024). This included allowPrivilegeEscalation and NET_BIND_SERVICE. Sometimes this could cause issues in some secure environments.

Solution: Remove these extra privileges and take advantage of sysctls to lower the allowed port range for the pod its defined on.

Testing: Verified that everything still works, including in OpenShift.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Fix port binding with reduced privileges.

Problem: The nginx deployment was using extra privileges in order to bind to privileged ports (<1024). This included `allowPrivilegeEscalation` and `NET_BIND_SERVICE`. Sometimes this could cause issues in some secure environments.

Solution: Remove these extra privileges and take advantage of `sysctls` to lower the allowed port range for the pod its defined on.
@sjberman sjberman requested a review from a team as a code owner July 3, 2025 19:05
@github-actions github-actions bot added bug Something isn't working helm-chart Relates to helm chart labels Jul 3, 2025
@sjberman sjberman enabled auto-merge (squash) July 3, 2025 19:06
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.19%. Comparing base (166f68e) to head (d5040d4).
Report is 1 commits behind head on release-2.0.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.0    #3590      +/-   ##
===============================================
+ Coverage        86.79%   95.19%   +8.40%     
===============================================
  Files              127        1     -126     
  Lines            15081      229   -14852     
  Branches            62       62              
===============================================
- Hits             13089      218   -12871     
+ Misses            1840       11    -1829     
+ Partials           152        0     -152     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman sjberman merged commit 51cf307 into release-2.0 Jul 3, 2025
50 checks passed
@sjberman sjberman deleted the fix/port-binding branch July 3, 2025 21:43
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working helm-chart Relates to helm chart release-notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants