Skip to content

Update scorecard workflow to use GITHUB_TOKEN #3564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

ciarams87
Copy link
Contributor

Proposed changes

Problem: The scorecard workflow is failing due to the use of a PAT

Solution: Update the workflow to use the GITHUB_TOKEN instead

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@ciarams87 ciarams87 requested a review from a team as a code owner June 30, 2025 09:56
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jun 30, 2025
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.84%. Comparing base (7d26857) to head (db6cc7a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3564      +/-   ##
==========================================
- Coverage   86.90%   86.84%   -0.06%     
==========================================
  Files         127      127              
  Lines       15218    15218              
  Branches       62       62              
==========================================
- Hits        13225    13216       -9     
- Misses       1843     1850       +7     
- Partials      150      152       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman
Copy link
Collaborator

Is the goal that this token will also help with all of our other failing workflows (pushing commits, opening PRs)?

@ciarams87
Copy link
Contributor Author

Is the goal that this token will also help with all of our other failing workflows (pushing commits, opening PRs)?

@sjberman This is updating just this scorecard workflow to using the inbuilt GITHUB_TOKEN instead of this bespoke PAT which no longer has access. It's been done (and seems to work) in a few of the other open source repos 😄

@sjberman
Copy link
Collaborator

@ciarams87 Yeah, I see this is just for scorecard, I was mainly just curious if we think a similar change will end up helping those other workflow issues.

@ciarams87 ciarams87 force-pushed the chore/update-scorecard-token branch from e6557d2 to f46cd5c Compare June 30, 2025 18:39
@ciarams87 ciarams87 enabled auto-merge (squash) June 30, 2025 18:39
@ciarams87 ciarams87 force-pushed the chore/update-scorecard-token branch from f46cd5c to db6cc7a Compare July 1, 2025 07:51
@ciarams87 ciarams87 merged commit 0712b4f into main Jul 1, 2025
62 of 64 checks passed
@ciarams87 ciarams87 deleted the chore/update-scorecard-token branch July 1, 2025 09:10
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants