Hpa #3492

nowjean · 2025-06-11T09:23:25Z

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: I want NGF to work with a HorizontalPodAutoscaler

Solution: Add HPA for deployement

Testing: Describe any testing that you did.
I've deployed my AKS cluster and checked hpa working correctly.

Closes #3447

Checklist

Before creating a PR, run through this checklist and mark each as complete.

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have checked that all unit tests pass after adding my changes
I have updated necessary documentation
I have rebased my branch onto main
I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

nginx-bot · 2025-06-11T09:23:29Z

Hi @nowjean! Welcome to the project! 🎉

Thanks for opening this pull request!
Be sure to check out our Contributing Guidelines while you wait for someone on the team to review this.

github-actions · 2025-06-11T09:23:34Z

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
_{Posted by the CLA Assistant Lite bot.}

nowjean · 2025-06-11T09:27:08Z

I have hereby read the F5 CLA and agree to its terms

salonichf5 · 2025-06-13T22:08:31Z

Thank you for you contribution to the project. Please run make generate-all from root directory to auto generate schema files.

charts/nginx-gateway-fabric/values.yaml

nowjean · 2025-06-14T01:36:30Z

Thank you for you contribution to the project. Please run make generate-all from root directory to auto generate schema files.

I’ve completed 'make generate-all'. Could you please review my PR?

sjberman · 2025-06-17T14:54:05Z

So this only affects the control plane, correct? We probably want to support this for the nginx data plane as well (seems like that would be the more beneficial use case).

In order to configure deployment options for the data plane, it requires a bit more work, specifically in our APIs and the code itself. The NginxProxy CRD holds the deployment configuration for the nginx data plane, which the control plane uses to configure the data plane when deploying it.

Here is a simple example of how we add a new field to the API to allow for configuring these types of deployment fields: #3319.

sjberman · 2025-06-17T15:07:25Z

I'd also love a more descriptive PR title, as well as a release note in the description so we can include this feature in our release notes :)

nowjean · 2025-06-17T15:33:45Z

@sjberman Yes, this PR only affects the control plane. Can we also implement HPA for the data plane?

AFAIK, the data plane Deployment is created by the NginxProxy CRD, and its name depends on the Gateway's name parameter. This means we can't assume a fixed name in values.yaml.

HPA only applies to Deployments with a fixed name, like:

scaleTargetRef:
  apiVersion: apps/v1
  kind: Deployment
  name: my-app

So, I think we can't implement HPA via the Helm chart, especially since data plane and control plane pods are now separated in 2.0.
Do you have any suggestions or recommended approaches for enabling HPA on the data plane?

sjberman · 2025-06-17T15:35:19Z

@nowjean I updated my comment with a description on how it can be implemented on the data plane side. Glad we're on the same page :)

salonichf5 · 2025-06-18T03:50:29Z

Thank you for you contribution to the project. Please run make generate-all from root directory to auto generate schema files.

I’ve completed 'make generate-all'. Could you please review my PR?

Will manual test this PR for both control plane and data plane when we have all the changes :)

nowjean · 2025-06-20T07:56:19Z

@sjberman @salonichf5 I've pushed my changes to this PR.
This is my first time working with Golang and creating CRDs, so I’d appreciate your review.

From my testing, the code correctly applies HPA to both the control plane and data plane.
To enable this, please set nginx.autoscaling.enabled: true and configure nginx.container.resources accordingly.

salonichf5 · 2025-06-20T21:22:22Z

Testing applying these HPA for control plane and data plane pods

Control plane pod

values.yaml

  autoscaling:
    # Enable or disable Horizontal Pod Autoscaler
    enabled: true
    annotations: {
       example.com/test: "true" 
    }
    minReplicas: 2
    maxReplicas: 4
    targetCPUUtilizationPercentage: 60
    targetMemoryUtilizationPercentage: 70
    behavior: 
      scaleUp:
        stabilizationWindowSeconds: 100
        policies:
        - type: Pods
          value: 2
          periodSeconds: 20
      scaleDown:
        stabilizationWindowSeconds: 200
        policies:
        - type: Pods
          value: 1
          periodSeconds: 20
  autoscalingTemplate: 
  - type: Pods
    pods:
      metric:
        name: nginx_gateway_fabric_nginx_process_requests_total
      target:
        type: AverageValue
        averageValue: 10000m

HPA details

k describe horizontalpodautoscalers.autoscaling -n nginx-gateway ngf-nginx-gateway-fabric
Name:                                                     ngf-nginx-gateway-fabric
Namespace:                                                nginx-gateway
Labels:                                                   app.kubernetes.io/instance=ngf
                                                          app.kubernetes.io/managed-by=Helm
                                                          app.kubernetes.io/name=nginx-gateway-fabric
                                                          app.kubernetes.io/version=edge
                                                          helm.sh/chart=nginx-gateway-fabric-2.0.1
Annotations:                                              example.com/test: true
                                                          meta.helm.sh/release-name: ngf
                                                          meta.helm.sh/release-namespace: nginx-gateway
CreationTimestamp:                                        Fri, 20 Jun 2025 14:16:18 -0600
Reference:                                                Deployment/ngf-nginx-gateway-fabric
Metrics:                                                  ( current / target )
  resource memory on pods  (as a percentage of request):  <unknown> / 70%
  resource cpu on pods  (as a percentage of request):     <unknown> / 60%
Min replicas:                                             2
Max replicas:                                             4
Behavior:
  Scale Up:
    Stabilization Window: 100 seconds
    Select Policy: Max
    Policies:
      - Type: Pods  Value: 2  Period: 20 seconds
  Scale Down:
    Stabilization Window: 200 seconds
    Select Policy: Max
    Policies:
      - Type: Pods  Value: 1  Period: 20 seconds
Deployment pods:    2 current / 2 desired
Conditions:
  Type           Status  Reason                   Message
  ----           ------  ------                   -------
  AbleToScale    True    SucceededGetScale        the HPA controller was able to get the target's current scale
  ScalingActive  False   FailedGetResourceMetric  the HPA was unable to compute the replica count: failed to get memory utilization: unable to get metrics for resource memory: unable to fetch metrics from resource metrics API: the server could not find the requested resource (get pods.metrics.k8s.io)
Events:
  Type     Reason                        Age                 From                       Message
  ----     ------                        ----                ----                       -------
  Normal   SuccessfulRescale             11m                 horizontal-pod-autoscaler  New size: 2; reason: Current number of replicas below Spec.MinReplicas
  Warning  FailedGetResourceMetric       9m5s (x8 over 10m)  horizontal-pod-autoscaler  failed to get cpu utilization: unable to get metrics for resource cpu: unable to fetch metrics from resource metrics API: the server could not find the requested resource (get pods.metrics.k8s.io)
  Warning  FailedComputeMetricsReplicas  9m5s (x8 over 10m)  horizontal-pod-autoscaler  invalid metrics (2 invalid out of 2), first error is: failed to get memory resource metric value: failed to get memory utilization: unable to get metrics for resource memory: unable to fetch metrics from resource metrics API: the server could not find the requested resource (get pods.metrics.k8s.io)
  Warning  FailedGetResourceMetric       50s (x41 over 10m)  horizontal-pod-autoscaler  failed to get memory utilization: unable to get metrics for resource memory: unable to fetch metrics from resource metrics API: the server could not find the requested resource (get pods.metrics.k8s.io)

Needed to install the metrics server (enabling insecure TLS) to get metrics for resource memory and ScalingActive is false since i did not set memory request.

should this be communicated to end user about setting additional fields if we want scaling to be active

Auto scaling set for both control plane and data plane pods

values.yaml


# NGINX Gateway Fabric

  resources:
    requests:
      cpu: "100m"
      memory: "128Mi"
    limits:
      cpu: "500m"
      memory: "256Mi"

  autoscaling:
    # Enable or disable Horizontal Pod Autoscaler
    enabled: true
    annotations: {
       example.com/test: "true" 
    }
    minReplicas: 2
    maxReplicas: 4
    targetCPUUtilizationPercentage: 60
    targetMemoryUtilizationPercentage: 70
    behavior: 
      scaleUp:
        stabilizationWindowSeconds: 100
        policies:
        - type: Pods
          value: 2
          periodSeconds: 20
      scaleDown:
        stabilizationWindowSeconds: 200
        policies:
        - type: Pods
          value: 1
          periodSeconds: 20
  autoscalingTemplate: 
  - type: Pods
    pods:
      metric:
        name: nginx_gateway_fabric_nginx_process_requests_total
      target:
        type: AverageValue
        averageValue: 10000m
        


#  NGINX Deployment
  autoscaling:
    # Enable or disable Horizontal Pod Autoscaler
    enabled: true
    hpaAnnotations: {
        cafe.example.com/test: "true"
    }
    minReplicas: 2
    maxReplicas: 4
    targetCPUUtilizationPercentage: 40
    targetMemoryUtilizationPercentage: 30
    behavior:
      scaleDown:
        stabilizationWindowSeconds: 100
        policies:
        - type: Pods
          value: 3
          periodSeconds: 20
      scaleUp:
        stabilizationWindowSeconds: 50
        policies:
        - type: Pods
          value: 1
          periodSeconds: 20



  container:
    # -- The resource requirements of the NGINX container. You should be set this value, If you want to use dataplane Autoscaling(HPA).
    resources:
      requests:
        cpu: 500m
        memory: 2Gi

k describe horizontalpodautoscalers.autoscaling -n nginx-gateway ngf-nginx-gateway-fabric
Name:                                                     ngf-nginx-gateway-fabric
Namespace:                                                nginx-gateway
Labels:                                                   app.kubernetes.io/instance=ngf
                                                          app.kubernetes.io/managed-by=Helm
                                                          app.kubernetes.io/name=nginx-gateway-fabric
                                                          app.kubernetes.io/version=edge
                                                          helm.sh/chart=nginx-gateway-fabric-2.0.1
Annotations:                                              example.com/test: true
                                                          meta.helm.sh/release-name: ngf
                                                          meta.helm.sh/release-namespace: nginx-gateway
CreationTimestamp:                                        Fri, 20 Jun 2025 14:56:42 -0600
Reference:                                                Deployment/ngf-nginx-gateway-fabric
Metrics:                                                  ( current / target )
  resource memory on pods  (as a percentage of request):  21% (29343744) / 70%
  resource cpu on pods  (as a percentage of request):     7% (7m) / 60%
Min replicas:                                             2
Max replicas:                                             4
Behavior:
  Scale Up:
    Stabilization Window: 100 seconds
    Select Policy: Max
    Policies:
      - Type: Pods  Value: 2  Period: 20 seconds
  Scale Down:
    Stabilization Window: 200 seconds
    Select Policy: Max
    Policies:
      - Type: Pods  Value: 1  Period: 20 seconds
Deployment pods:    2 current / 2 desired
Conditions:
  Type            Status  Reason            Message
  ----            ------  ------            -------
  AbleToScale     True    ReadyForNewScale  recommended size matches current size
  ScalingActive   True    ValidMetricFound  the HPA was able to successfully calculate a replica count from memory resource utilization (percentage of request)
  ScalingLimited  True    TooFewReplicas    the desired replica count is less than the minimum replica count
Events:
  Type     Reason                   Age    From                       Message
  ----     ------                   ----   ----                       -------
  Normal   SuccessfulRescale        5m40s  horizontal-pod-autoscaler  New size: 2; reason: Current number of replicas below Spec.MinReplicas
  Warning  FailedGetResourceMetric  5m25s  horizontal-pod-autoscaler  failed to get cpu utilization: did not receive metrics for targeted pods (pods might be unready)

I saw HPA get configured for control plane pod but i couldn't see one configured for data plane pod.

Events from the nginx deployment and logs could normal.

helm template ngf ./charts/nginx-gateway-fabric -f ./charts/nginx-gateway-fabric/values.yaml
# Source: nginx-gateway-fabric/templates/hpa.yaml
apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
  annotations: 
    example.com/test: "true"
  labels:
    helm.sh/chart: nginx-gateway-fabric-2.0.1
    app.kubernetes.io/name: nginx-gateway-fabric
    app.kubernetes.io/instance: ngf
    app.kubernetes.io/version: "edge"
    app.kubernetes.io/managed-by: Helm
  name: ngf-nginx-gateway-fabric
  namespace: default
spec:
  scaleTargetRef:
    apiVersion: apps/v1
    kind: Deployment
    name: ngf-nginx-gateway-fabric
  minReplicas: 2
  maxReplicas: 4
  metrics:
  - type: Resource
    resource:
      name: memory
      target:
        type: Utilization
        averageUtilization: 70
  - type: Resource
    resource:
      name: cpu
      target:
        type: Utilization
        averageUtilization: 60
  behavior:
    scaleDown:
      policies:
      - periodSeconds: 20
        type: Pods
        value: 1
      stabilizationWindowSeconds: 200
    scaleUp:
      policies:
      - periodSeconds: 20
        type: Pods
        value: 2
      stabilizationWindowSeconds: 100

The NginxProxy resource reflects resources value but not autoscaling fields

k describe nginxproxies.gateway.nginx.org -n nginx-gateway ngf-proxy-config
Name:         ngf-proxy-config
Namespace:    nginx-gateway
Labels:       app.kubernetes.io/instance=ngf
              app.kubernetes.io/managed-by=Helm
              app.kubernetes.io/name=nginx-gateway-fabric
              app.kubernetes.io/version=edge
              helm.sh/chart=nginx-gateway-fabric-2.0.1
Annotations:  meta.helm.sh/release-name: ngf
              meta.helm.sh/release-namespace: nginx-gateway
API Version:  gateway.nginx.org/v1alpha2
Kind:         NginxProxy
Metadata:
  Creation Timestamp:  2025-06-20T20:56:42Z
  Generation:          1
  Resource Version:    481755
  UID:                 6140ca30-cd48-4b13-b53f-a7e382f842db
Spec:
  Ip Family:  dual
  Kubernetes:
    Deployment:
      Container:
        Image:
          Pull Policy:  Never
          Repository:   nginx-gateway-fabric/nginx
          Tag:          sa.choudhary
        Resources:
          Requests:
            Cpu:     500m
            Memory:  2Gi
      Replicas:      1
    Service:
      External Traffic Policy:  Local
      Type:                     LoadBalancer
Events:                         <none>

So a couple of observations

you are not specifying scaleTargetRef in NGINXProxy resource
also, during helm install i am running into error that unknown field "spec.kubernetes.deployment.autoscaling" from the NginxProxy template. So API has been updated but maybe something up with how yaml is nested.
I think this could be a possible issue. I did spend some time debugging and adding target refs but that failed too

W0620 15:33:11.844029   43067 warnings.go:70] unknown field "spec.kubernetes.deployment.autoscaling"
W0620 15:33:11.844075   43067 warnings.go:70] unknown field "spec.scaleTargetRef"

What am I doing wrong in terms of testing ? @sjberman @nowjean

nowjean · 2025-06-21T02:09:17Z

@salonichf5 @sjberman Thanks for testing!

Please refer to below guide and review my PR again.

I've patched Makefile generate-crds

crd:maxDescLen=0

This option off the description of CRDs. Because, new nginxProxy manifest file occurs

The CustomResourceDefinition "nginxproxies.gateway.nginx.org" is invalid: metadata.annotations: Too long: must have at most 262144 byte

Rebuild the image
I’ve updated the CRDs, so please rebuild the NGF Docker image:
make generate-all.
make build-ngf-image.
(You’ll find this target in the Makefile.)
Apply new NginxProxy CRD.

kubectl apply -f gateway.nginx.org_nginxproxies.yaml

Point Helm to the new image
Edit values.yaml so the Helm chart uses the image you just built:

 image:
   # -- The NGINX Gateway Fabric image to use
   repository: ghcr.io/nginx/nginx-gateway-fabric  # → replace with your new image
   tag: edge  # → replace with your new tag

(In my case, I had to upgrade my runc version to build ngf docker images.)

Deploy the Helm chart

The control-plane HPA is created automatically by the Helm template.
The data-plane HPA is created by each Gateway resource, because every NginxProxy manages its own control-plane Deployment, Service, and so on. After you apply a Gateway, you’ll see an HPA for its Deployment.

End-users can create multiple Gateways, and each one needs its own HPA, so the logic now lives in the Gateway resource.

Plus, I'm not sure about this part:

Needed to install the metrics server (enabling insecure TLS) to get metrics for resource memory and ScalingActive is false >since i did not set memory request.
should this be communicated to end user about setting additional fields if we want scaling to be active

Normally, we assume that end users already have the Metrics Server running if they're using HPA or similar features. But maybe it's worth adding a note in the docs to avoid confusion.

nowjean · 2025-06-24T09:04:55Z

@salonichf5 @sjberman I added feature of autoscalingTemplate for Dataplane HPA. For me, It is working correctly.

salonichf5 · 2025-06-25T03:06:26Z

Looks good now @nowjean ! Thank you so much for your contribution, I'll run the pipeline now -- need to ensure the CRD changes don't lead to any issues.

I did verify and ran into the issue. The NginxProxy API is getting larger and complex leading to these issues. FYI @sjberman @ciarams87

values.yaml

nginx:
  container:
    # -- The resource requirements of the NGINX container. You should be set this value, If you want to use dataplane Autoscaling(HPA).
    resources:
      requests:
        cpu: 500m
        memory: 2Gi

  autoscaling:
    # Enable or disable Horizontal Pod Autoscaler
    enabled: true
    hpaAnnotations: {
        cafe.example.com/test: "true"
    }
    minReplicas: 2
    maxReplicas: 4
    targetCPUUtilizationPercentage: 40
    targetMemoryUtilizationPercentage: 30
    behavior:
      scaleDown:
        stabilizationWindowSeconds: 100
        policies:
        - type: Pods
          value: 3
          periodSeconds: 20
      scaleUp:
        stabilizationWindowSeconds: 50
        policies:
        - type: Pods
          value: 1
          periodSeconds: 20


nginxGateway:
  autoscaling:
    # Enable or disable Horizontal Pod Autoscaler
    enabled: true
    annotations: {
       example.com/test: "true" 
    }
    minReplicas: 2
    maxReplicas: 4
    targetCPUUtilizationPercentage: 60
    targetMemoryUtilizationPercentage: 70
    behavior: 
      scaleUp:
        stabilizationWindowSeconds: 100
        policies:
        - type: Pods
          value: 2
          periodSeconds: 20
      scaleDown:
        stabilizationWindowSeconds: 200
        policies:
        - type: Pods
          value: 1
          periodSeconds: 20
  autoscalingTemplate: 
  - type: Pods
    pods:
      metric:
        name: nginx_gateway_fabric_nginx_process_requests_total
      target:
        type: AverageValue
        averageValue: 10000m

k describe horizontalpodautoscalers.autoscaling gateway-nginx

Name:                                                     gateway-nginx
Namespace:                                                default
Labels:                                                   app.kubernetes.io/instance=ngf
                                                          app.kubernetes.io/managed-by=ngf-nginx
                                                          app.kubernetes.io/name=gateway-nginx
                                                          gateway.networking.k8s.io/gateway-name=gateway
Annotations:                                              cafe.example.com/test: true
CreationTimestamp:                                        Tue, 24 Jun 2025 21:00:44 -0600
Reference:                                                Deployment/gateway-nginx
Metrics:                                                  ( current / target )
  resource cpu on pods  (as a percentage of request):     <unknown> / 40%
  resource memory on pods  (as a percentage of request):  <unknown> / 30%
Min replicas:                                             2
Max replicas:                                             4
Behavior:
  Scale Up:
    Stabilization Window: 50 seconds
    Select Policy: Max
    Policies:
      - Type: Pods  Value: 1  Period: 20 seconds
  Scale Down:
    Stabilization Window: 100 seconds
    Select Policy: Max
    Policies:
      - Type: Pods  Value: 3  Period: 20 seconds
Deployment pods:    1 current / 2 desired
Conditions:
  Type         Status  Reason            Message
  ----         ------  ------            -------
  AbleToScale  True    SucceededRescale  the HPA controller was able to update the target scale to 2
Events:
  Type    Reason             Age               From                       Message
  ----    ------             ----              ----                       -------
  Normal  SuccessfulRescale  7s (x2 over 22s)  horizontal-pod-autoscaler  New size: 2; reason: Current number of replicas below Spec.MinReplicas

k describe horizontalpodautoscalers.autoscaling -n nginx-gateway ngf-nginx-gateway-fabric
Name:                                                     ngf-nginx-gateway-fabric
Namespace:                                                nginx-gateway
Labels:                                                   app.kubernetes.io/instance=ngf
                                                          app.kubernetes.io/managed-by=Helm
                                                          app.kubernetes.io/name=nginx-gateway-fabric
                                                          app.kubernetes.io/version=edge
                                                          helm.sh/chart=nginx-gateway-fabric-2.0.1
Annotations:                                              example.com/test: true
                                                          meta.helm.sh/release-name: ngf
                                                          meta.helm.sh/release-namespace: nginx-gateway
CreationTimestamp:                                        Tue, 24 Jun 2025 21:00:41 -0600
Reference:                                                Deployment/ngf-nginx-gateway-fabric
Metrics:                                                  ( current / target )
  resource memory on pods  (as a percentage of request):  <unknown> / 70%
  resource cpu on pods  (as a percentage of request):     <unknown> / 60%
Min replicas:                                             2
Max replicas:                                             4
Behavior:
  Scale Up:
    Stabilization Window: 100 seconds
    Select Policy: Max
    Policies:
      - Type: Pods  Value: 2  Period: 20 seconds
  Scale Down:
    Stabilization Window: 200 seconds
    Select Policy: Max
    Policies:
      - Type: Pods  Value: 1  Period: 20 seconds
Deployment pods:    2 current / 2 desired
Conditions:
  Type           Status  Reason                   Message
  ----           ------  ------                   -------
  AbleToScale    True    SucceededGetScale        the HPA controller was able to get the target's current scale
  ScalingActive  False   FailedGetResourceMetric  the HPA was unable to compute the replica count: failed to get memory utilization: missing request for memory in container nginx-gateway of Pod ngf-nginx-gateway-fabric-b45ffc8d6-lsfpv

nowjean · 2025-06-25T07:22:01Z

run the pipeline

@salonichf5 Thanks, I got some errors in the pipeline and fixing now.. So, How can I run the pipeline?

salonichf5 · 2025-06-25T22:33:12Z

run the pipeline

@salonichf5 Thanks, I got some errors in the pipeline and fixing now.. So, How can I run the pipeline?

re-running it for you now, only we can approve pipeline's run but i'll keep a closer look at your PR. Appreciate your work :)

can you rebase your work with main?

# from the main branch, pull latest changes to local

git fetch --all
git pull upstream main

# from your branch

git rebase main

salonichf5 · 2025-06-25T23:27:02Z

pre-commit.ci autofix

nowjean · 2025-06-25T23:27:14Z

@salonichf5 Thanks for your guide:)
Here are the commands I executed.

git remote add upstream https://github.com/nginx/nginx-gateway-fabric.git
git fetch upstream
git rebase upstream/main
git push -f origin hpa

After that, I checked commit history my hpa branch.
It seems to have worked well.

git log --oneline --graph

178326a (HEAD -> hpa, origin/hpa) Fix Pipeline err
3d2b56c Add control/data plane HPA
39bce01 (upstream/main) Update dependency prettier to v3.6.1 (Update dependency prettier to v3.6.1 #3542)
e7b2a5f Update pre-commit hook rbubley/mirrors-prettier to v3.6.0 (Update pre-commit hook rbubley/mirrors-prettier to v3.6.0 #3537)

nowjean · 2025-06-25T23:39:01Z

pre-commit.ci autofix

I forgot to run make generate-all before committing.
I just pushed the update. Sorry to bother you😢

salonichf5 · 2025-06-26T02:55:55Z

internal/controller/provisioner/objects.go

@@ -160,7 +163,25 @@ func (p *NginxProvisioner) buildNginxResourceObjects(
 	if p.isOpenshift {
 		objects = append(objects, openshiftObjs...)
 	}
-	objects = append(objects, service, deployment)
+
+	if nProxyCfg.Kubernetes.Deployment.Autoscaling.Enabled {


there's need to be a nil check for Autoscaling here

Suggested change

if nProxyCfg.Kubernetes.Deployment.Autoscaling.Enabled {

if nProxyCfg.Kubernetes.Deployment.Autoscaling != nil {

if nProxyCfg.Kubernetes.Deployment.Autoscaling.Enabled {

Thanks, I updated above code and test cases.

nowjean requested a review from a team as a code owner June 11, 2025 09:23

github-project-automation bot added this to NGINX Gateway Fabric Jun 11, 2025

github-project-automation bot moved this to 🆕 New in NGINX Gateway Fabric Jun 11, 2025

nginx-bot bot added the community label Jun 11, 2025

github-actions bot added the helm-chart Relates to helm chart label Jun 11, 2025

sjberman moved this from 🆕 New to External Pull Requests in NGINX Gateway Fabric Jun 12, 2025

salonichf5 reviewed Jun 13, 2025

View reviewed changes

charts/nginx-gateway-fabric/values.yaml Outdated Show resolved Hide resolved

nowjean force-pushed the hpa branch from 8075053 to 365bcb7 Compare June 14, 2025 01:31

nowjean requested a review from a team as a code owner June 14, 2025 01:31

github-actions bot added the documentation Improvements or additions to documentation label Jun 14, 2025

nowjean force-pushed the hpa branch 2 times, most recently from 172c009 to d081d68 Compare June 14, 2025 07:20

sjberman added the enhancement New feature or request label Jun 17, 2025

github-actions bot removed the enhancement New feature or request label Jun 20, 2025

nowjean force-pushed the hpa branch 3 times, most recently from c57e992 to e8399d9 Compare June 24, 2025 09:01

nowjean force-pushed the hpa branch from e8399d9 to e064420 Compare June 24, 2025 09:11

nowjean added 2 commits June 26, 2025 08:19

Add control/data plane HPA

3d2b56c

Fix Pipeline err

178326a

nowjean force-pushed the hpa branch from 2ad9be5 to 178326a Compare June 25, 2025 23:21

Update generated files

8d6e67a

nowjean force-pushed the hpa branch from 2d6cb48 to 8d6e67a Compare June 25, 2025 23:34

salonichf5 reviewed Jun 26, 2025

View reviewed changes

Add Test case

d264650

salonichf5 mentioned this pull request Jun 26, 2025

Generated annotations too long leading to issues when CRD is being applied #3549

Open

Refactoring

c53d713

	if nProxyCfg.Kubernetes.Deployment.Autoscaling.Enabled {
	if nProxyCfg.Kubernetes.Deployment.Autoscaling != nil {
	if nProxyCfg.Kubernetes.Deployment.Autoscaling.Enabled {

Hpa #3492

Are you sure you want to change the base?

Hpa #3492

Conversation

nowjean commented Jun 11, 2025

Proposed changes

Checklist

Release notes

Uh oh!

nginx-bot bot commented Jun 11, 2025

Uh oh!

github-actions bot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nowjean commented Jun 11, 2025

Uh oh!

salonichf5 commented Jun 13, 2025

Uh oh!

Uh oh!

nowjean commented Jun 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sjberman commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sjberman commented Jun 17, 2025

Uh oh!

nowjean commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sjberman commented Jun 17, 2025

Uh oh!

salonichf5 commented Jun 18, 2025

Uh oh!

nowjean commented Jun 20, 2025

Uh oh!

salonichf5 commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nowjean commented Jun 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nowjean commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

salonichf5 commented Jun 25, 2025

Uh oh!

nowjean commented Jun 25, 2025

Uh oh!

salonichf5 commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

salonichf5 commented Jun 25, 2025

Uh oh!

nowjean commented Jun 25, 2025

Uh oh!

nowjean commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

salonichf5 Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

nowjean Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jun 11, 2025 •

edited

Loading

nowjean commented Jun 14, 2025 •

edited

Loading

sjberman commented Jun 17, 2025 •

edited

Loading

nowjean commented Jun 17, 2025 •

edited

Loading

salonichf5 commented Jun 20, 2025 •

edited

Loading

nowjean commented Jun 21, 2025 •

edited

Loading

nowjean commented Jun 24, 2025 •

edited

Loading

salonichf5 commented Jun 25, 2025 •

edited

Loading

nowjean commented Jun 25, 2025 •

edited

Loading