-
Notifications
You must be signed in to change notification settings - Fork 127
Support configurable hostPort in helm chart #3321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
5d59c04
6dcba57
b956397
1f7f09a
185ced7
40f2b70
bbf9a67
8317ade
ab12cf4
bfe712d
fb1abc5
343d24a
f9ba83d
13897e1
eed4093
50b3400
bb6fb37
60fd6fd
995eaa5
8f2e721
ed1d0c5
3253d56
4a2868d
2e6a1ce
1dc1850
d45d0e7
aba383d
e8522bb
cc0b116
abefe49
191cfdd
809f714
837e6da
7bdf85b
53fa9e6
6b0f5f5
7053cd4
e8545de
74ca56b
6043820
03b10b2
6a02149
4fcc11e
1cc4cb7
4d52817
b132050
5d9fdc2
4a294ad
33ed8d4
f959180
db7296c
1f2cd18
57cf833
2f1fce5
917b477
5f0744a
94fa1c3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -402,7 +402,33 @@ nginx: | |
|
||
# -- The container configuration for the NGINX container. This is applied globally to all Gateways managed by this | ||
# instance of NGINX Gateway Fabric. | ||
container: {} | ||
container: | ||
# @schema | ||
# type: array | ||
# items: | ||
# type: object | ||
# properties: | ||
# port: | ||
# type: integer | ||
# required: true | ||
# minimum: 1 | ||
# maximum: 65535 | ||
# containerPort: | ||
# type: integer | ||
# required: true | ||
# minimum: 1 | ||
# maximum: 65535 | ||
# @schema | ||
# -- A list of HostPorts to expose on the host. | ||
# This configuration allows containers to bind to a specific port on the host node, | ||
# enabling external network traffic to reach the container directly through the host's IP address and port. | ||
# Use this option when you need to expose container ports on the host for direct access, | ||
# such as for debugging, legacy integrations, or when NodePort/LoadBalancer services are not suitable. | ||
# Note: Using hostPort may have security and scheduling implications, as it ties pods to specific nodes and ports. | ||
hostPorts: [] | ||
Gasoid marked this conversation as resolved.
Show resolved
Hide resolved
|
||
# - port: 80 | ||
# containerPort: 80 | ||
|
||
# -- The resource requirements of the NGINX container. | ||
# resources: {} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since you updated the template to filter empty fields, can we uncomment the other fields in the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok, let me do this |
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually needs to have a
+
beforekubebuilder
in order to render properly. It looks like our NodePort struct has this mistake as well. Do you mind updating all of these?// +kubebuilder:validation:Minimum=1
for example.