Skip to content

some cleanup in prep for open sourcing #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2024
Merged

some cleanup in prep for open sourcing #196

merged 3 commits into from
Jun 6, 2024

Conversation

ryepup
Copy link
Collaborator

@ryepup ryepup commented Jun 5, 2024

Proposed changes

Some cleanup prior to open sourcing:

  1. get ready to use the nginx NPM organization instead of the nginxinc github organization
  2. a warning fix
  3. some README changes

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

ryepup added 3 commits June 3, 2024 10:56
Our npm organization is `nginx`, not `nginxinc`, renames across the
board and a few incidental `devDependencies` updates.
It wanted us to be explicit about our options instead of relying on
the default values.
- prep for public npm consumption
- simplify / rework a little
@ryepup ryepup merged commit 5e88f23 into main Jun 6, 2024
3 checks passed
@ryepup ryepup deleted the npm branch June 6, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants