Open
Conversation
Member
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1986 +/- ##
========================================
Coverage 95.18% 95.18%
========================================
Files 270 270
Lines 8765 8772 +7
Branches 1705 1813 +108
========================================
+ Hits 8343 8350 +7
Misses 335 335
Partials 87 87 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AveryZhang
reviewed
Feb 6, 2026
| ); | ||
| } | ||
|
|
||
| private save(type: 'm' | 's', key: string, value: ICache, emitNotify: boolean = true): void { |
There was a problem hiding this comment.
save方法,应该要能返回异步promise,毕竟底层的存储可能是异步的,不这样做,调用方就不知道何时save完成了。。同理,其它很多方法,可能都要改成返回异步对象才行。甚至,程序刚运行,在打开底层的存储库时,打开方法,也是异步的,如果不等存储库打开完成,就直接读取或者存储,就会报错。
There was a problem hiding this comment.
对外公开的方法,如open,set, get,remove clear等方法,可能都要能返回异步结果。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information