Skip to content

[stable34] fix(files): proper accessible row name and title for overflow #61930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
susnux wants to merge 2 commits into
base: stable34
Choose a base branch
from
+9 −8
Open

[stable34] fix(files): proper accessible row name and title for overflow #61930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4936e4
fix(files): proper accessible row name and title for overflow
susnux Jun 29, 2026
a351c5a
chore(assets): Recompile assets
nextcloud-command Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions apps/files/src/components/FileEntry/FileEntryName.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export default defineComponent({
return {
is: 'span',
params: {
title: t('files', 'This node is unavailable'),
title: t('files', '{displayName} (unavailable)', { displayName: this.source.displayname }),
},
}
}
Expand All @@ -148,11 +148,12 @@ export default defineComponent({
folder: this.activeFolder!,
contents: [],
})
const accessibleName = `${displayName}: ${this.source.displayname}`
return {
is: 'button',
params: {
'aria-label': displayName,
title: displayName,
'aria-label': accessibleName,
title: accessibleName,
tabindex: '0',
},
}
Expand Down
4 changes: 2 additions & 2 deletions cypress/e2e/files_external/files-external-failed.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ describe('Files user credentials', { testIsolation: true }, () => {
// Ensure the row is visible and marked as unavailable
getRowForFile('Storage1').as('row').should('be.visible')
cy.get('@row').find('[data-cy-files-list-row-name-link]')
.should('have.attr', 'title', 'This node is unavailable')
.should('have.attr', 'title', / \(unavailable\)$/)

// Ensure clicking on the location does not open the folder
cy.location().then((loc) => {
Expand All @@ -74,7 +74,7 @@ describe('Files user credentials', { testIsolation: true }, () => {
// Ensure the row is visible and marked as unavailable
getRowForFile('Storage2').as('row').should('be.visible')
cy.get('@row').find('[data-cy-files-list-row-name-link]')
.should('have.attr', 'title', 'This node is unavailable')
.should('have.attr', 'title', / \(unavailable\)$/)

// Ensure clicking on the location does not open the folder
cy.location().then((loc) => {
Expand Down
4 changes: 2 additions & 2 deletions dist/files-main.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files-main.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading