fix(s3): trim multiple spaces to single space in original path header#61914
Open
leftybournes wants to merge 1 commit into
Open
fix(s3): trim multiple spaces to single space in original path header#61914leftybournes wants to merge 1 commit into
leftybournes wants to merge 1 commit into
Conversation
Signed-off-by: Kent Delante <kent@delante.me> The spec defines that x-amz-meta-original-path header needs spaces to be trimmed and multiple spaces need to be converted to a single space. This is to comply with the spec and fix it for some storage hosts that return a SignatureDoesNotMatch error when not done.
leftybournes
requested review from
Altahrim,
ArtificialOwl,
CarlSchwan and
salmart-dev
and removed request for
a team
CarlSchwan
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The S3 API spec defines that
x-amz-meta-original-pathheader needs spaces to be trimmed and multiple spaces need to be converted to a single space. This is to comply with the spec and fix it for some storage hosts that return aSignatureDoesNotMatcherror.The reference to the documentation can be found here in Task 1.4
Checklist
3. to review, feature component)stable32)AI (if applicable)