Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Conversation

@bfineran
Copy link
Contributor

No description provided.

* Update CONTRIBUTING.md

including Discourse and Slack

* Update README.md

Discourse and Slack link updates
Made link to Discourse more generic vs. category-specific

* Update index.rst

Updated nav to include Discourse and Slack
@bfineran bfineran requested review from a team, dhuangnm and jeanniefinks May 11, 2021 15:01
@bfineran bfineran self-assigned this May 11, 2021
@bfineran bfineran requested review from markurtz, mgoin and natuan and removed request for a team May 11, 2021 15:01
kevinaer
kevinaer previously approved these changes May 11, 2021
mgoin
mgoin previously approved these changes May 11, 2021
@neomatrix369
Copy link

Thanks for the links, just signed up on Discourse.

Is the Slack link a public one? I couldn't sign up on it, it expects a @neuralmagic.com email address.

@jeanniefinks good work with the PRs and commits ;)

Copy link
Member

@jeanniefinks jeanniefinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neomatrix369
Copy link

neomatrix369 commented May 11, 2021

@neomatrix369
Thank you for testing. May you see if this link works better?
https://join.slack.com/t/discuss-neuralmagic/shared_invite/zt-q1a1cnvo-YBoICSIw3L1dmQpjBeDurQ

Yes that worked perfect!
I'm on there now!

Although I was looking forward to DiscordApp ;)

* Update README.md

updating slack link with better link

* Update CONTRIBUTING.md

added better community links

* Update index.rst

added better community link
@neomatrix369
Copy link

@neomatrix369
Thank you for testing. May you see if this link works better?
https://join.slack.com/t/discuss-neuralmagic/shared_invite/zt-q1a1cnvo-YBoICSIw3L1dmQpjBeDurQ

@jeanniefinks one thing to know about Slack invite links, they expire in a short while (7 days max I think) -- you may want to check where this link is generated and if you can reset this expiry setting on it

@jeanniefinks
Copy link
Member

@neomatrix369
Thank you for testing. May you see if this link works better?
https://join.slack.com/t/discuss-neuralmagic/shared_invite/zt-q1a1cnvo-YBoICSIw3L1dmQpjBeDurQ

@jeanniefinks one thing to know about Slack invite links, they expire in a short while (7 days max I think) -- you may want to check where this link is generated and if you can reset this expiry setting on it

@neomatrix369 The one we are distributing doesn't expire. I think the Slack invite link process at some point realized that putting expirations on them (7 / 30 days etc.) was limiting on Slack admins. So they now have a "doesn't expire" option.
What's interesting is that the desktop experience is slightly different (better!) than the mobile one with those links. Too much to go into in this GitHub comment 😄

@neomatrix369
Copy link

@neomatrix369 The one we are distributing doesn't expire. I think the Slack invite link process at some point realized that putting expirations on them (7 / 30 days etc.) was limiting on Slack admins. So they now have a "doesn't expire" option.
What's interesting is that the desktop experience is slightly different (better!) than the mobile one with those links. Too much to go into in this GitHub comment 😄

Okay that's good, cause past experience means I have had these expiring links, glad its not present anymore

@jeanniefinks jeanniefinks self-requested a review May 11, 2021 21:39
@bfineran bfineran merged commit 7b9999b into release/0.3 May 12, 2021
@bfineran bfineran deleted the slack-dc-pick branch May 12, 2021 04:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants