DecoratorExtension: do not decorate accessors by inner type (possible BC break)

Author: dg

src/DI/Extensions/DecoratorExtension.php

@@ -61,7 +61,8 @@ public function addTags($type, array $tags)
 	private function findByType($type)
 	{
 		return array_filter($this->getContainerBuilder()->getDefinitions(), function ($def) use ($type) {
-			return is_a($def->getType(), $type, true) || is_a($def->getImplement(), $type, true);
+			return is_a($def->getImplement(), $type, true)
+				|| ($def->getImplementMode() !== $def::IMPLEMENT_MODE_GET && is_a($def->getType(), $type, true));
 		});
 	}
 }

tests/DI/DecoratorExtension.factories.accessor.phpt

@@ -0,0 +1,47 @@
+<?php
+
+/**
+ * Test: Nette\DI\Compiler: service decorators && generated factories
+ */
+
+use Nette\DI;
+use Tester\Assert;
+
+
+require __DIR__ . '/../bootstrap.php';
+
+interface FooAccessor
+{
+
+	/**
+	 * @return Foo
+	 */
+	public function get();
+}
+
+class Foo
+{
+}
+
+
+$compiler = new DI\Compiler;
+$compiler->addExtension('decorator', new Nette\DI\Extensions\DecoratorExtension);
+$container = createContainer($compiler, '
+decorator:
+	Foo:
+		inject: yes
+	FooAccessor:
+		tags: [a]
+services:
+	foo: Foo
+	acc: {implement: FooAccessor}
+');
+
+
+$builder = $compiler->getContainerBuilder();
+
+Assert::true($builder->getDefinition('foo')->getTag('inject'));
+Assert::null($builder->getDefinition('foo')->getTag('a'));
+
+Assert::null($builder->getDefinition('acc')->getTag('inject'));
+Assert::true($builder->getDefinition('acc')->getTag('a'));