ContainerBuilder: added check that accessor have no setup

Author: dg

src/DI/ContainerBuilder.php

@@ -423,6 +423,8 @@ private function resolveImplement(ServiceDefinition $def, $name)
 		if ($rc->hasMethod('get')) {
 			if ($method->getParameters()) {
 				throw new ServiceCreationException("Method $methodName used in service '$name' must have no arguments.");
+			} elseif ($def->getSetup()) {
+				throw new ServiceCreationException("Service accessor '$name' must have no setup.");
 			}
 			if (!$def->getEntity()) {
 				$def->setFactory('@\\' . ltrim($def->getType(), '\\'));

tests/DI/Compiler.generatedFactory.phpt

@@ -311,3 +311,17 @@ Assert::exception(function () {
 	$builder->addDefinition('one')->setImplement('Bad6')->setFactory('Bad5');
 	$builder->complete();
 }, Nette\InvalidStateException::class, 'Unused parameter $baz when implementing method Bad6::create().');
+
+
+
+interface Bad7
+{
+	public function get();
+}
+
+Assert::exception(function () {
+	$builder = new DI\ContainerBuilder;
+	$builder->addDefinition('stdClass')->setFactory('stdClass');
+	$builder->addDefinition('one')->setImplement('Bad7')->setClass('stdClass')->addSetup('method');
+	$builder->complete();
+}, Nette\InvalidStateException::class, "Service accessor 'one' must have no setup.");