Skip to content

feat(talos): add overridable timeout for auto install #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ruant wants to merge 1 commit into
base: development
Choose a base branch
from
+2 −1
Open

feat(talos): add overridable timeout for auto install #1644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion roles/netbootxyz/templates/menu/talos.ipxe.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ iseq ${os_arch} arm64 && set os_arch arm64 ||
isset ${talos_version} || set talos_version latest
isset ${talos_mirror} || set talos_mirror {{ releases.talos.mirror }}
isset ${talos_platform} || set talos_platform metal
isset ${install_timeout} || set install_timeout 60000

Copilot AI Dec 18, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name install_timeout is too generic and could conflict with other menu contexts. Consider using a more specific name like talos_timeout or talos_menu_timeout to follow the pattern established by other Talos-specific variables like talos_version, talos_mirror, and talos_platform.

Copilot uses AI. Check for mistakes.
menu ${os} by Talos Systems
menu ${os} install
item --gap Talos:
Expand All @@ -23,7 +24,7 @@ item talos_version ${space} ${os} version: ${talos_version}
item talos_config_url ${space} Set userdata.yaml URL: ${talos_config_url}
item talos_mirror ${space} Set mirror URL: ${talos_mirror}
item talos_platform ${space} Set platform: ${talos_platform}
choose --default ${menu} menu || goto talos_exit
choose --timeout ${install_timeout} --default ${menu} menu || goto talos_exit
echo ${cls}
goto ${menu} ||
goto talos_exit
Expand Down