-
Notifications
You must be signed in to change notification settings - Fork 195
Split OSM plugin from server plugin #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split OSM plugin from server plugin #462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR splits OpenStreetMap (OSM) functionality from the main server plugin into a separate, optional osm-server-plugin module. This architectural change allows users to optionally include OSM support by adding the OSM plugin JAR alongside the main server plugin.
Key changes:
- Created new
osm-server-pluginmodule with OSM-specific classes, procedures, and resources - Moved OSM classes from
org.neo4j.gis.spatial.osmtoorg.neo4j.spatial.osm.server.pluginpackage - Updated all imports, tests, and documentation to reference the new package structure
- Split META-INF service provider files between the two plugins
Reviewed changes
Copilot reviewed 64 out of 77 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
osm-server-plugin/pom.xml |
New module POM with OSM-specific dependencies and build configuration |
osm-server-plugin/src/main/java/** |
Moved OSM classes to new package structure |
osm-server-plugin/src/test/java/** |
Moved and updated OSM-related tests |
server-plugin/src/test/java/** |
Updated tests to remove OSM dependencies and create synthetic test data |
server-plugin/pom.xml |
Removed OSM test dependencies |
pom.xml |
Added new osm-server-plugin module |
docs/** |
Updated documentation to indicate OSM as optional |
README.md |
Added notes about optional OSM plugin |
doc-examples/** |
Updated to import from new OSM package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
osm-server-plugin/src/test/java/org/neo4j/spatial/osm/server/plugin/OsmLayerSignatureTest.java
Outdated
Show resolved
Hide resolved
Test Results 28 files +4 28 suites +4 16m 56s ⏱️ + 1m 0s Results for commit ac4f5fa. ± Comparison against base commit 918205f. This pull request removes 20 and adds 23 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
…ructure and renaming files for better organization.
05c187e to
ac4f5fa
Compare
This PR splits OpenStreetMap (OSM) functionality from the main server plugin into a separate, optional
osm-server-pluginmodule. This architectural change allows users to optionally include OSM support by adding the OSM plugin JAR alongside the main server plugin.Key changes:
osm-server-pluginmodule with OSM-specific classes, procedures, and resourcesorg.neo4j.gis.spatial.osmtoorg.neo4j.spatial.osm.server.pluginpackage