Skip to content

Conversation

@Andy2003
Copy link
Collaborator

@Andy2003 Andy2003 commented Dec 23, 2025

This PR splits OpenStreetMap (OSM) functionality from the main server plugin into a separate, optional osm-server-plugin module. This architectural change allows users to optionally include OSM support by adding the OSM plugin JAR alongside the main server plugin.

Key changes:

  • Created new osm-server-plugin module with OSM-specific classes, procedures, and resources
  • Moved OSM classes from org.neo4j.gis.spatial.osm to org.neo4j.spatial.osm.server.plugin package
  • Updated all imports, tests, and documentation to reference the new package structure
  • Split META-INF service provider files between the two plugins

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR splits OpenStreetMap (OSM) functionality from the main server plugin into a separate, optional osm-server-plugin module. This architectural change allows users to optionally include OSM support by adding the OSM plugin JAR alongside the main server plugin.

Key changes:

  • Created new osm-server-plugin module with OSM-specific classes, procedures, and resources
  • Moved OSM classes from org.neo4j.gis.spatial.osm to org.neo4j.spatial.osm.server.plugin package
  • Updated all imports, tests, and documentation to reference the new package structure
  • Split META-INF service provider files between the two plugins

Reviewed changes

Copilot reviewed 64 out of 77 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
osm-server-plugin/pom.xml New module POM with OSM-specific dependencies and build configuration
osm-server-plugin/src/main/java/** Moved OSM classes to new package structure
osm-server-plugin/src/test/java/** Moved and updated OSM-related tests
server-plugin/src/test/java/** Updated tests to remove OSM dependencies and create synthetic test data
server-plugin/pom.xml Removed OSM test dependencies
pom.xml Added new osm-server-plugin module
docs/** Updated documentation to indicate OSM as optional
README.md Added notes about optional OSM plugin
doc-examples/** Updated to import from new OSM package

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Dec 23, 2025

Test Results

 28 files  +4   28 suites  +4   16m 56s ⏱️ + 1m 0s
353 tests +3  329 ✅ +3  24 💤 ±0  0 ❌ ±0 
284 runs  +3  260 ✅ +3  24 💤 ±0  0 ❌ ±0 

Results for commit ac4f5fa. ± Comparison against base commit 918205f.

This pull request removes 20 and adds 23 tests. Note that renamed tests count towards both.
org.neo4j.gis.spatial.LayerSignatureTest ‑ testDynamicLayer
org.neo4j.gis.spatial.LayersTest ‑ testShapefileExport
org.neo4j.gis.spatial.OsmAnalysisTest ‑ runTest(String, int, int)[1]
org.neo4j.gis.spatial.OsmAnalysisTest ‑ runTest(String, int, int)[2]
org.neo4j.gis.spatial.TestDynamicLayers ‑ testImageExport_HighwayShp
org.neo4j.gis.spatial.TestDynamicLayers ‑ testShapefileExport_Map1
org.neo4j.gis.spatial.TestDynamicLayers ‑ testShapefileExport_Map2
org.neo4j.gis.spatial.TestOSMImport ‑ buildDataModel
org.neo4j.gis.spatial.TestOSMImport ‑ runTest(String, boolean)[1]
org.neo4j.gis.spatial.TestOSMImport ‑ runTest(String, boolean)[2]
…
org.neo4j.spatial.osm.server.plugin.OsmAnalysisTest ‑ runTest(String, int, int)[1]
org.neo4j.spatial.osm.server.plugin.OsmAnalysisTest ‑ runTest(String, int, int)[2]
org.neo4j.spatial.osm.server.plugin.OsmLayerSignatureTest ‑ testDynamicLayer
org.neo4j.spatial.osm.server.plugin.OsmLayersTest ‑ testEditableLayers
org.neo4j.spatial.osm.server.plugin.OsmLayersTest ‑ testShapefileExport
org.neo4j.spatial.osm.server.plugin.TestDynamicLayers ‑ testImageExport_HighwayShp
org.neo4j.spatial.osm.server.plugin.TestDynamicLayers ‑ testShapefileExport_Map1
org.neo4j.spatial.osm.server.plugin.TestDynamicLayers ‑ testShapefileExport_Map2
org.neo4j.spatial.osm.server.plugin.TestIntersectsPathQueries ‑ testPointSetGeoptimaIntersection
org.neo4j.spatial.osm.server.plugin.TestOSMImport ‑ buildDataModel
…

♻️ This comment has been updated with latest results.

…ructure and renaming files for better organization.
@Andy2003 Andy2003 force-pushed the feature/split-up-osm-plugin-from-server-plugin branch from 05c187e to ac4f5fa Compare December 23, 2025 12:31
@Andy2003 Andy2003 merged commit 40da0fb into master Dec 23, 2025
2 checks passed
@Andy2003 Andy2003 deleted the feature/split-up-osm-plugin-from-server-plugin branch December 23, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants