Extracts test utilities and example generation code into a separate module #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR extracts test utilities and example generation code into a separate test-utils module to improve code organization and reusability. The refactoring moves common test infrastructure from server-plugin to a dedicated module that can be shared across the project.
Key changes:
- Created new
test-utilsmodule with shared test utilities and base test classes - Moved and refactored
Neo4jTestCaseandAbstractApiTestto the new module - Consolidated utility methods from
Neo4jTestUtilsintoSpatialTestUtils - Updated all test classes to use the new module structure
- Added example data files (shapefile and OSM) for documentation generation
Reviewed changes
Copilot reviewed 39 out of 147 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test-utils/pom.xml | New Maven module for shared test utilities with dependencies on Neo4j test harness and JUnit |
| test-utils/src/main/java/org/neo4j/spatial/testutils/SpatialTestUtils.java | New utility class consolidating spatial test helper methods |
| test-utils/src/main/java/org/neo4j/spatial/testutils/Neo4jTestCase.java | Refactored base test class moved to test-utils module with abstract method for loading procedures |
| test-utils/src/main/java/org/neo4j/spatial/testutils/AbstractApiTest.java | Refactored API test base class moved to test-utils module |
| server-plugin/src/test/java/org/neo4j/gis/spatial/Neo4jTestUtils.java | Deleted - functionality moved to SpatialTestUtils |
| server-plugin/src/test/java/org/neo4j/gis/spatial/procedures/SpatialProceduresTest.java | Updated to use new test-utils module and removed example generation code |
| server-plugin/pom.xml | Added dependency on new test-utils module |
| pom.xml | Added test-utils and doc-examples modules to parent POM |
| example-data/shp/* | Added shapefile example data for documentation |
| example-data/osm/example.osm | Added OSM example data for documentation |
| docs/docs/modules/ROOT/partials/generated/api/spatial/* | Updated generated documentation files with correct file paths and generator references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Andy2003
changed the title
Andy2003
deleted the
feature/extract-example-geneartion-into-own-module
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts test utilities and example generation code into a separate
test-utilsmodule to improve code organization and reusability. The refactoring moves common test infrastructure fromserver-pluginto a dedicated module that can be shared across the project.Key changes:
test-utilsmodule with shared test utilities and base test classesNeo4jTestCaseandAbstractApiTestto the new moduleNeo4jTestUtilsintoSpatialTestUtils