Refactor layer type registration using LayerTypePresets to centralize and streamline configuration management.
#457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ze and streamline configuration management.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors layer type registration by introducing a LayerTypePresets interface and ServiceLoader-based discovery mechanism to centralize and streamline configuration management. The hardcoded layer type registrations in SpatialDatabaseService are extracted into separate preset classes that can be discovered and loaded dynamically.
- Introduced
LayerTypePresetsinterface withRegisteredLayerTyperecord to define layer type configurations - Migrated layer type registrations from static initialization to ServiceLoader-based discovery
- Split layer type definitions into
SpatialLayerTypePresets(general types) andOsmSpatialLayerTypePresets(OSM-specific)
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
api/src/main/java/org/neo4j/spatial/api/layer/LayerTypePresets.java |
Defines the new LayerTypePresets interface and RegisteredLayerType record for layer type configuration |
server-plugin/src/main/resources/META-INF/services/org.neo4j.spatial.api.layer.LayerTypePresets |
ServiceLoader configuration file listing the preset implementations |
server-plugin/src/main/java/org/neo4j/gis/spatial/SpatialLayerTypePresets.java |
Implementation providing general spatial layer type presets (SimplePoint, WKT, WKB, etc.) |
server-plugin/src/main/java/org/neo4j/gis/spatial/OsmSpatialLayerTypePresets.java |
Implementation providing OSM-specific layer type preset |
server-plugin/src/main/java/org/neo4j/gis/spatial/SpatialDatabaseService.java |
Refactored to use ServiceLoader for loading presets, removed hardcoded registrations and inner RegisteredLayerType class |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
server-plugin/src/main/java/org/neo4j/gis/spatial/SpatialDatabaseService.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This PR refactors layer type registration by introducing a
LayerTypePresetsinterface and ServiceLoader-based discovery mechanism to centralize and streamline configuration management. The hardcoded layer type registrations inSpatialDatabaseServiceare extracted into separate preset classes that can be discovered and loaded dynamically.LayerTypePresetsinterface withRegisteredLayerTyperecord to define layer type configurationsSpatialLayerTypePresets(general types) andOsmSpatialLayerTypePresets(OSM-specific)