Preserve onClick/keyUp/keyDown event listener for Touchables #1348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, React Native for Web handles some edge cases for Touchables which lead to unexpected behaviour.
Example:
vs
For key events its even more extreme and might block propagation, but only if ENTER was used.
A little bit of context:
I develop a SmartTV App with React Native Web, in which I implemented spatial navigation (via arrow keys) in which I need to be able to globally handle ENTER events, this allows for a workaround.
What would already work help would be the removal of
e.stopPropagation()
. I was unsure whether this solves a specific problem, so I chose the opt-out method instead.This makes my workaround from #1219 usable.