Skip to content

ci: bind workflow_dispatch release-type via env before shell - #16170

Open
SashaMIT wants to merge 1 commit into
near:masterfrom
SashaMIT:ci/bind-release-type-input-env
Open

ci: bind workflow_dispatch release-type via env before shell#16170
SashaMIT wants to merge 1 commit into
near:masterfrom
SashaMIT:ci/bind-release-type-input-env

Conversation

@SashaMIT

@SashaMIT SashaMIT commented Aug 5, 2026

Copy link
Copy Markdown

Summary

  • Bind github.event.inputs.release-type through env: RELEASE_TYPE before invoking ./scripts/binary_release.sh.
  • Same class as GitHub’s documented script-injection guidance for interpolating workflow_dispatch inputs into run: scripts.

Test plan

  • Manual dispatch with a release-type still builds/uploads as before

Made with Cursor

Pass github.event.inputs.release-type through env: before
binary_release.sh (script-injection class).

Co-authored-by: Cursor <cursoragent@cursor.com>
@SashaMIT
SashaMIT requested a review from a team as a code owner August 5, 2026 13:03
@SashaMIT
SashaMIT requested a review from saketh-are August 5, 2026 13:03
@greptile-apps

greptile-apps Bot commented Aug 5, 2026

Copy link
Copy Markdown

Greptile Summary

This PR safely passes the manually dispatched release type to the release script through a quoted environment variable instead of interpolating it directly into shell source.

  • Adds RELEASE_TYPE to the release step environment.
  • Quotes the variable when forwarding it to binary_release.sh, preserving it as one argument and preventing shell interpretation.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The workflow still passes the selected release type as one argument to the release script while avoiding direct insertion of dispatch input into shell source.

Reviews (1): Last reviewed commit: "ci: bind workflow_dispatch release-type ..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant