ci: bind workflow_dispatch release-type via env before shell - #16170
Open
SashaMIT wants to merge 1 commit into
Open
ci: bind workflow_dispatch release-type via env before shell#16170SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
Pass github.event.inputs.release-type through env: before binary_release.sh (script-injection class). Co-authored-by: Cursor <cursoragent@cursor.com>
Greptile SummaryThis PR safely passes the manually dispatched release type to the release script through a quoted environment variable instead of interpolating it directly into shell source.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The workflow still passes the selected release type as one argument to the release script while avoiding direct insertion of dispatch input into shell source. Reviews (1): Last reviewed commit: "ci: bind workflow_dispatch release-type ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.event.inputs.release-typethroughenv: RELEASE_TYPEbefore invoking./scripts/binary_release.sh.workflow_dispatchinputs intorun:scripts.Test plan
Made with Cursor