Strange behavior #170 #177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemDintecom
suggested changes
Jul 17, 2023
|
|
||
| rawValue = isNumber ? new Number(rawValue).toFixed(precision) : rawValue; | ||
| let onlyNumbers = rawValue.replace(this.ONLY_NUMBERS_REGEX, ""); | ||
| let onlyNumbers = rawValue.replace(suffix,"").replace(this.ONLY_NUMBERS_REGEX, ""); |
There was a problem hiding this comment.
I think that suffix can be anything and it cannot be simply removed from any position of rawValue. It would be better to check that the string ends with suffix and remove suffix.length characters from the end of rawValue.
I think you can similarly remove prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please verify this issue, if it is fixed please merged this into main and publish. Need this on urgent basis.